-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[iOS] Fixing #28912 by only hiding context buttons when user already stopped dragging the cell #28914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VitalyKnyazev
wants to merge
14
commits into
dotnet:main
Choose a base branch
from
VitalyKnyazev:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[iOS] Fixing #28912 by only hiding context buttons when user already stopped dragging the cell #28914
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0d96f16
Fixed issue 26769 - crash when iOS app is running on MacOS and "More"…
VitalyKnyazev 016424a
Merge branch 'dotnet:main' into main
VitalyKnyazev f3495ff
Merge branch 'dotnet:main' into main
VitalyKnyazev 6773f1a
Fixed iOS cell resizing issue #23319, CellRenderer.GetCell may not be…
VitalyKnyazev 8866e7b
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev 87e67fc
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev 8686af3
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev 80ca3af
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev b31d9b1
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev 73a9f92
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev a9ae654
Merge branch 'main' of https://github.com/VitalyKnyazev/maui
VitalyKnyazev 5355600
Fixed potential NRE probably due to copy/paste bug
VitalyKnyazev 2e9e7b0
Fixed #28912 by hiding context menu buttons only if user ever swiped …
VitalyKnyazev 354572a
Better fix for #28912
VitalyKnyazev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While can understand the changes in the ContextScrollViewDelegate class, I think need more context here? why are you changing this condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this change is not related to the main issue, but it is clearly a copy/paste bug and can cause NRE in the next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to roll back this one if needed