Fixed Test case failure in PR 29037 - [2025/04/21] Candidate #29049
Conversation
|
Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
HarishKumarSF4517
requested review from
jfversluis and
jsuarezruiz
and removed request for
a team
src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The Windows snapshot doesn't look right. If SetBlur(10) is used on the canvas, I expect the specified radius (10) to be visibly blurred. I believe this works correctly on Android. So either this is a bug on Windows, or I might be mistaken.
There was a problem hiding this comment.
|
@PureWeen @bhavanesh2001 As per the current implementation on Windows, the GaussianBlurEffect only supports applying blur to the entire visual content, as documented here: https://learn.microsoft.com/en-us/windows/win32/direct2d/gaussian-blur. Therefore, the current output image on Windows is expected and aligns with the platform's behavior, as there is no available API to apply the blur effect selectively based on corner values. Shall we proceed with the current image? Please share your thoughts or concerns. |
|
@anandhan-rajagopal Keeping the snapshot doesn’t seem right to me. The expected behavior is that the blur should be applied within the specified radius. Windows not supporting that directly is more of a limitation we should handle, not something we should lock in as the correct output. maui/src/Graphics/src/Graphics/IBlurrableCanvas.cs Lines 3 to 6 in b43b974 |
Hi @bhavanesh2001 , Thank you for your feedback. For now, I have decided to consider the Windows issues separately and have excluded Windows from the test case accordingly, along with linking the relevant issue report |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
### Description of Change ## .NET MAUI Release Notes - Inflight/Candidate ## What's Changed ### MAUI Product Fixes * Fix CarouselView layout SR6 regressions by @albyrock87 in #29035 * Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen in https://github.com/dotnet/maui/pull/1fb5164929 * [Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in #28996 * [Android] picker - focus/unfocus events by @kubaflo in #28122 * [XC] add IRootObjectProvider by @StephaneDelcroix in #28310 * [iOS] Fix for the File.ContentType from MediaPicker not being in valid MIME format by @SyedAbdulAzeemSF4852 in #28842 * [Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage by @Ahamed-Ali in #28844 * [iOS] Fix FlyoutPage does not respond to changes in the FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in #28884 * [Android] Fixed ScalingCanvas.SetBlur not working by @NirmalKumarYuvaraj in #28911 * [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in CV2 by @prakashKannanSf3972 in #28641 * [iOS] Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in #28890 * [Windows] - Fix Visual State Issue with Picker TextColor After Navigation by @prakashKannanSf3972 in #28746 ### Dependency Updates * [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in #28499 ### Testing * [Testing] Feature Matrix UITest Cases for CollectionView EmptyView Feature by @NafeelaNazhir in #28679 * Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by @HarishKumarSF4517 in #29049 **Full Changelog**: main...inflight/candidate For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
Description
This pull request includes changes to resolve the test failures on Candidate PR(#29037) and included the copilot code suggestion on the PhoneFlyoutPageRenderer class to improve code clarity and correctness.
Test cases:
Issue8632 - Changed the conditional compilation directive in Issue8632.cs from || (logical OR) to && (logical AND) to refine the conditions under which the test is excluded.
Issue28536 - Added base line image generated from CI.