Skip to content

Fixed Test case failure in PR 29037 - [2025/04/21] Candidate #29049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
Merged

Fixed Test case failure in PR 29037 - [2025/04/21] Candidate #29049

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6223e17
Added the base snapshots
HarishKumarSF4517 Apr 17, 2025
fd3c551
Updated Copilot suggestion
HarishKumarSF4517 Apr 17, 2025
57a491d
Update PhoneFlyoutPageRenderer.cs
HarishKumarSF4517 Apr 17, 2025
7244037
Update Issue28536.cs
HarishKumarSF4517 Apr 17, 2025
fec9cca
Update Issue8632.cs
HarishKumarSF4517 Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Controls/src/Core/Compatibility/Handlers/FlyoutPage/iOS/PhoneFlyoutPageRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,7 @@ void LayoutChildren(bool animated)
void UpdateFlyoutLayoutBehaviorChanges()
{
LayoutChildren(true);
FlyoutPage flyoutPage = Element as FlyoutPage;
if (flyoutPage == null)
if (FlyoutPage is null)
return;
FlyoutLayoutBehavior flyoutBehavior = FlyoutPage.FlyoutLayoutBehavior;
bool shouldPresent = FlyoutPageController.ShouldShowSplitMode;
Expand All @@ -491,7 +490,7 @@ void UpdateFlyoutLayoutBehaviorChanges()
shouldPresent = false;
}

if (shouldPresent != flyoutPage.IsPresented)
if (shouldPresent != FlyoutPage.IsPresented)
{
((IElementController)Element).SetValueFromRenderer(FlyoutPage.IsPresentedProperty, shouldPresent);
UpdateLeftBarButton();
Expand Down
Binary file added ....Android.Tests/snapshots/android/CheckNavigationBreaksVisualStatesForPicker.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...estCases.Mac.Tests/snapshots/mac/CheckNavigationBreaksVisualStatesForPicker.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28536.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public void CheckNavigationBreaksVisualStatesForPicker()
{
App.WaitForElement("VisualStatePicker");
App.Tap(Switch);
App.WaitForElement("NavigateButton");
App.Tap("NavigateButton");
App.WaitForElement("Next Page");
App.TapBackArrow();
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8632.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if TEST_FAILS_ON_IOS || TEST_FAILS_ON_CATALYST // https://github.com/dotnet/maui/issues/28910
#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST // https://github.com/dotnet/maui/issues/28910
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down
Binary file added ...ontrols/tests/TestCases.WinUI.Tests/snapshots/windows/CanvasShouldHonorBlur.png
View file
Open in desktop
Copy link
Contributor

@bhavanesh2001 bhavanesh2001 Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows snapshot doesn't look right. If SetBlur(10) is used on the canvas, I expect the specified radius (10) to be visibly blurred. I believe this works correctly on Android. So either this is a bug on Windows, or I might be mistaken.
CanvasShouldHonorBlur

Copy link
Contributor

@anandhan-rajagopal anandhan-rajagopal Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavanesh2001 FYI #29049 (comment)

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...es.WinUI.Tests/snapshots/windows/CheckNavigationBreaksVisualStatesForPicker.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.