Skip to content

Resolve ide0040, ide0051, ide0052, ide0350 warnings #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Apr 17, 2025

These are showing up when building with a recent .NET 10 SDK. This allows us to remove the warnAsError=false flag in the VMR when building msbuild

Review with hide whitespaces toggled one:

image

Fixes #

Context

Changes Made

Testing

Notes

These are showing up when building with a recent .NET 10 SDK.
This allows us to remove the warnAsError=false flag in the VMR when building msbuild
@ViktorHofer ViktorHofer marked this pull request as ready for review April 17, 2025 13:54
@Copilot Copilot AI review requested due to automatic review settings April 17, 2025 13:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.

@ViktorHofer ViktorHofer requested a review from a team April 17, 2025 15:15
@ViktorHofer
Copy link
Member Author

@dotnet/kitten PTAL

@ViktorHofer
Copy link
Member Author

Can you please also merge this PR? I don't have permissions to do so.

@YuliiaKovalova YuliiaKovalova merged commit d5ac662 into main Apr 22, 2025
10 checks passed
@YuliiaKovalova YuliiaKovalova deleted the ResolveCompilerWarningsFrom10SDK branch April 22, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants