Clean-up VMR repo projects #48436
Merged
Clean-up VMR repo projects #48436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove -warnaserror=false when not necessary anymore - Remove LogVerbosityOptOut - Remove the PublishWindowsPdb switch which got removed in arcade - Remove unnecessary version flow in arcade.proj
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
added a commit
to dotnet/msbuild
that referenced
this pull request
Apr 14, 2025
Observed in dotnet/sdk#48436 Fixes IDE0040, IDE0350, IDE0052 and IDE0051
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (17)
- src/SourceBuild/content/repo-projects/Directory.Build.targets: Language not supported
- src/SourceBuild/content/repo-projects/arcade.proj: Language not supported
- src/SourceBuild/content/repo-projects/aspnetcore.proj: Language not supported
- src/SourceBuild/content/repo-projects/command-line-api.proj: Language not supported
- src/SourceBuild/content/repo-projects/deployment-tools.proj: Language not supported
- src/SourceBuild/content/repo-projects/fsharp.proj: Language not supported
- src/SourceBuild/content/repo-projects/msbuild.proj: Language not supported
- src/SourceBuild/content/repo-projects/roslyn-analyzers.proj: Language not supported
- src/SourceBuild/content/repo-projects/roslyn.proj: Language not supported
- src/SourceBuild/content/repo-projects/runtime.proj: Language not supported
- src/SourceBuild/content/repo-projects/sdk.proj: Language not supported
- src/SourceBuild/content/repo-projects/sourcelink.proj: Language not supported
- src/SourceBuild/content/repo-projects/templating.proj: Language not supported
- src/SourceBuild/content/repo-projects/windowsdesktop.proj: Language not supported
- src/SourceBuild/content/repo-projects/winforms.proj: Language not supported
- src/SourceBuild/content/repo-projects/wpf.proj: Language not supported
- src/SourceBuild/content/repo-projects/xdt.proj: Language not supported
This was referenced Apr 18, 2025
ViktorHofer
added a commit
to ViktorHofer/NuGet.Client
that referenced
this pull request
Apr 18, 2025
3 tasks
akoeplinger
approved these changes
Apr 18, 2025
| <LogVerbosityOptOut>true</LogVerbosityOptOut> | ||
|
|
||
| <BuildArgs>$(BuildArgs) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg)</BuildArgs> | ||
| <!-- When building source only, dependencies get updated which trigger new nullability warnings. --> |
There was a problem hiding this comment.
do we have a tracking issue for that? since eventually we'll see it in the VMR build too
There was a problem hiding this comment.
The remaining roslyn-analyzers component (NetAnalyzers) will be moved into sdk soon (ETA: May-June). The warnings will then show up as part of the move and naturally resolved.
|
|
||
| <!-- | ||
| Setting NETCoreAppMaximumVersion to a high version so that the sdk doesn't complain if we're restoring/publishing for a higher version than the sdk. | ||
| See https://github.com/dotnet/sdk/issues/1512#issuecomment-377082883 |
There was a problem hiding this comment.
why do we no longer need this?
There was a problem hiding this comment.
We will rev to the next major version differently with the VMR for .NET 11. At that point I expect that we will globally flow a set of properties in to the inner repos which will allow to target the next major version. The property is currently not needed as maximum version is 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3539
Keep the warnAsError setting in msbuild and wpf for now. For the msbuild one, I submitted dotnet/msbuild#11740