Skip to content

Cleanup CodeAnalysis suppression for GC.Collect #11814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

Erarndt
Copy link
Contributor

@Erarndt Erarndt commented May 8, 2025

Fixes #

Context

Changes Made

Testing

Notes

@Copilot Copilot AI review requested due to automatic review settings May 8, 2025 16:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an explicit call to GC.Collect() in the OutOfProcNode.cs file to prevent unnecessary manual garbage collection.

  • Removed explicit GC.Collect() call
  • Updated memory cleanup logic by relying on automatic garbage collection

SimaTian added 3 commits May 12, 2025 09:56
Removing the now-unnecessary compiler directive.
removing unused directive.
@SimaTian
Copy link
Member

With the branch update, it now reports correctly that the GC.Collect is already gone.
That being said, I will use this PR to remove the now redundant compiler directive as suggested in the conversation.

@JanProvaznik JanProvaznik changed the title Avoid explicitly calling GC.Collect() Cleanup CodeAnalysis suppression for GC.Collect May 12, 2025
@JanProvaznik JanProvaznik merged commit 9bd4f91 into dotnet:main May 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants