Skip to content

Cleanup CodeAnalysis suppression for GC.Collect #11814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 4 commits into from
May 12, 2025
Merged

Cleanup CodeAnalysis suppression for GC.Collect #11814

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a52086
Avoid explicitly calling GC.Collect()
Erarndt May 8, 2025
e727e3b
Update OutOfProcNode.cs
SimaTian May 12, 2025
e752673
Update OutOfProcNode.cs
SimaTian May 12, 2025
877293c
Merge branch 'main' into dev/erarndt/GCCollect
SimaTian May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Build/BackEnd/Node/OutOfProcNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.IO;
using System.Threading;
Expand Down Expand Up @@ -542,7 +541,6 @@ private NodeEngineShutdownReason HandleShutdown(out Exception exception)
/// <summary>
/// Clears all the caches used during the build.
/// </summary>
[SuppressMessage("Microsoft.Reliability", "CA2001:AvoidCallingProblematicMethods", MessageId = "System.GC.Collect", Justification = "Required because when calling this method, we want the memory back NOW.")]
private void CleanupCaches()
{
if (_componentFactories.GetComponent(BuildComponentType.ConfigCache) is IConfigCache configCache)
Expand Down