Support RID-specific .NET Tool packages #48575
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Create a new abstract base class called ToolPackageDownloaderBase. Refactor #ToolPackageDownloader to derive from ToolPackageDownloaderBase, and move the implementation into the base class.
Refactor the creation of the NuGetPackageDownloader instance into an abstract method named CreateNuGetPackageDownloader in ToolPackageDownloaderBase , and move the implementation into ToolPackageDownloader
Refactor #method:'Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloaderBase.CreateNuGetPackageDownloader':2769-3057 and the calls to it to remove method parameters: The packageInstallDir can always be a default DirectoryPath. It doesn't need to differ based on whether a tool is global or local. The creation of the ILogger can be moved into the implementation of the method. Instead of passing an ILogger parameter, a verbosity parameter can be passed.
Remove the packageInstallDir variable in #method:'Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloader.CreateNuGetPackageDownloader':1156-2039 .
Refactor #method:'Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloaderBase.CreateNuGetPackageDownloader':2769-2983 to return #interface:'Microsoft.DotNet.Cli.NuGetPackageDownloader.INuGetPackageDownloader':348-1612 . The implementation in #class:'Microsoft.DotNet.Cli.ToolPackage.ToolPackageDownloader':832-1978 will also need to be updated.
…tion Copilot couldn't handle this apparently, it was trying to delete a bunch of extra code.
New version uses the base class which is factored so that the mock doesn't have to reimplement a bunch of product logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, currently supports RID-specific packages for global tools.