-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release/10.0.2xx] Update dependencies from dotnet/dotnet #51425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/10.0.2xx] Update dependencies from dotnet/dotnet #51425
Conversation
…006.3 On relative base path root dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.NET.HostModel , Microsoft.NET.Sdk.WindowsDesktop , Microsoft.NETCore.Platforms , Microsoft.WindowsDesktop.App.Internal From Version 10.0.0-rtm.25515.111 -> To Version 10.0.0-rc.2.25506.103 Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.TestHost , Microsoft.Bcl.AsyncInterfaces , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.Win32.SystemEvents , Microsoft.WindowsDesktop.App.Ref , System.CodeDom , System.ComponentModel.Composition , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions From Version 10.0.0 -> To Version 10.0.0-rc.2.25506.103 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 10.0.0-preview.25515.111 -> To Version 10.0.0-preview.25506.103 Microsoft.Build From Version 18.0.0 -> To Version 18.0.0-preview-25506-103 Microsoft.Build.Localization From Version 18.0.0-servicing-25515-111 -> To Version 18.0.0-preview-25506-103 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 7.0.0-rc.1611 -> To Version 7.0.0-preview.2.703 Microsoft.Build.Tasks.Git , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab From Version 10.0.0-beta.25515.111 -> To Version 10.0.0-beta.25506.103 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.BuildClient , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.PublicApiAnalyzers , Microsoft.CodeAnalysis.Workspaces.Common , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework From Version 5.0.0-2.25515.111 -> To Version 5.0.0-2.25506.103 Microsoft.Deployment.DotNet.Releases From Version 2.0.0-preview.1.25515.111 -> To Version 2.0.0-preview.1.25506.103 Microsoft.DiaSymReader From Version 2.2.0-beta.25515.111 -> To Version 2.2.0-beta.25506.103 Microsoft.FSharp.Compiler From Version 14.0.100-rc2.25515.111 -> To Version 14.0.100-rc2.25506.103 Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI From Version 18.0.0-release-25515-111 -> To Version 18.1.0-preview-25506-103 Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Authoring.TemplateVerifier , Microsoft.TemplateEngine.Edge , Microsoft.TemplateEngine.Orchestrator.RunnableProjects , Microsoft.TemplateEngine.Utils , Microsoft.TemplateSearch.Common From Version 10.0.100 -> To Version 10.0.100-rc.2.25506.103 Microsoft.TemplateEngine.Mocks , Microsoft.TemplateEngine.TestHelper , Microsoft.TemplateSearch.TemplateDiscovery From Version 10.0.100-rtm.25515.111 -> To Version 10.0.100-rc.2.25506.103 Microsoft.Web.Xdt From Version 3.2.0-preview.25515.111 -> To Version 3.2.0-preview.25506.103 System.CommandLine From Version 2.0.0 -> To Version 2.0.0-rc.2.25506.103
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…34e-4513-9c04-1e14d946eb65
|
@nagilson could you please take a look at the following build issue: |
…34e-4513-9c04-1e14d946eb65
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…34e-4513-9c04-1e14d946eb65
…34e-4513-9c04-1e14d946eb65
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
|
The RC2 runtime downgrade just went in. Need that to flow to 2xx and then come back before we reopen this. |
… darc-release/10.0.2xx-63df7914-e34e-4513-9c04-1e14d946eb65
| param( | ||
| [string]$NuGetExePath, | ||
| [string]$PackageSource = "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json", | ||
| [string]$PackageSource = "https://api.nuget.org/v3/index.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we undoing this change and going back to nuget.org? dotnet/arcade#16154
The main sdk version also seemed to undergo this change, and then undid this change, then undid that, so it's back to dotnet-public again.
Arcade is still using the dotnet-public feed. https://github.com/dotnet/arcade/blob/d78e0e9d17ca041656652ef10b8f5cb4f1f42475/eng/common/post-build/nuget-verification.ps1#L30.
Meanwhile, the dotnet/dotnet copy appears out of date: https://github.com/dotnet/dotnet/blob/main/eng/common/post-build/nuget-verification.ps1 and is using the old feed. Is this a mistake? That file hasn't been updated in over a year. @mmitche @dotnet/product-construction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotnet-dotnet copy aligns with rc2 arcade. This should be backflowing from the arcade in 2xx. That said, it does have the correct content: https://github.com/dotnet/dotnet/blob/release/10.0.2xx/src/arcade/eng/common/post-build/nuget-verification.ps1#L33
@premun Any idea what's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmitche this is the file that's flowing back here:
https://github.com/dotnet/dotnet/blob/5558d2da527906dd610d5bfa63177e67e515b5e7/eng/common/post-build/nuget-verification.ps1#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, it ain't, let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to wait for a newer build only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotnet-dotnet copy aligns with rc2 arcade. This should be backflowing from the arcade in 2xx. That said, it does have the correct content: https://github.com/dotnet/dotnet/blob/release/10.0.2xx/src/arcade/eng/common/post-build/nuget-verification.ps1#L33
@premun Any idea what's going on here?
I see that the src/ version is correct but https://github.com/dotnet/dotnet/blob/83e58331e1a8b88f1a5149cb39330fd6cb7b97fc/eng/common/post-build/nuget-verification.ps1#L33 the eng version is not correct. Maybe I don't understand the difference well enough and this is OK though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagilson from the description of this PR:
You need to be looking at the 5558d2d version of the file, not 83e5833 because the former already has a build that is flowing in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but I don't fully understand - Should we wait for a newer build to fix this and update to the newer logic? Would you suggest closing this PR? Or is this actually OK to merge for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagilson you can do whichever you prefer. I merely commented on the fact that the code flow is not going backwards, only a new enough commit of the VMR hasn't been built+flown yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is green now but the changes look like they might be going backwards. I'm concerned that dotnet/dotnet's arcade logic is missing some fixes.
…006.3 On relative base path root dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.Bcl.AsyncInterfaces , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64 , Microsoft.NET.Sdk.WindowsDesktop , Microsoft.NETCore.App.Ref , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , Microsoft.WindowsDesktop.App.Internal , Microsoft.WindowsDesktop.App.Ref , System.CodeDom , System.ComponentModel.Composition , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions From Version 10.0.0-rc.2.25502.107 -> To Version 10.0.0-rc.2.25506.103 Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport From Version 10.0.0-preview.25502.107 -> To Version 10.0.0-preview.25506.103 Microsoft.Build , Microsoft.Build.Localization From Version 18.0.0-preview-25502-107 -> To Version 18.0.0-preview-25506-103 Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning From Version 7.0.0-rc.307 -> To Version 7.0.0-preview.2.703 Microsoft.Build.Tasks.Git , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab From Version 10.0.0-beta.25502.107 -> To Version 10.0.0-beta.25506.103 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.BuildClient , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.CSharp.CodeStyle , Microsoft.CodeAnalysis.CSharp.Features , Microsoft.CodeAnalysis.CSharp.Workspaces , Microsoft.CodeAnalysis.PublicApiAnalyzers , Microsoft.CodeAnalysis.Workspaces.Common , Microsoft.CodeAnalysis.Workspaces.MSBuild , Microsoft.Net.Compilers.Toolset , Microsoft.Net.Compilers.Toolset.Framework From Version 5.0.0-2.25502.107 -> To Version 5.0.0-2.25506.103 Microsoft.Deployment.DotNet.Releases From Version 2.0.0-preview.1.25502.107 -> To Version 2.0.0-preview.1.25506.103 Microsoft.DiaSymReader From Version 2.2.0-beta.25502.107 -> To Version 2.2.0-beta.25506.103 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25522.2 -> To Version 10.0.0-beta.25506.103 Microsoft.FSharp.Compiler From Version 14.0.100-rc2.25502.107 -> To Version 14.0.100-rc2.25506.103 Microsoft.NET.Test.Sdk , Microsoft.TestPlatform.Build , Microsoft.TestPlatform.CLI From Version 18.0.0-preview-25502-107 -> To Version 18.1.0-preview-25506-103 Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Authoring.TemplateVerifier , Microsoft.TemplateEngine.Edge , Microsoft.TemplateEngine.Mocks , Microsoft.TemplateEngine.Orchestrator.RunnableProjects , Microsoft.TemplateEngine.TestHelper , Microsoft.TemplateEngine.Utils , Microsoft.TemplateSearch.Common , Microsoft.TemplateSearch.TemplateDiscovery From Version 10.0.100-rc.2.25502.107 -> To Version 10.0.100-rc.2.25506.103 Microsoft.Web.Xdt From Version 3.2.0-preview.25502.107 -> To Version 3.2.0-preview.25506.103 System.CommandLine From Version 2.0.0-rc.2.25502.107 -> To Version 2.0.0-rc.2.25506.103
|
I don't see a flow to dotnet/dotnet. I triggered manually but I'm worried it may be stuck again. I'll monitor and ping on the teams chat if it doesn't ever show up. |
…34e-4513-9c04-1e14d946eb65
…34e-4513-9c04-1e14d946eb65
|
I don't think it's a mistake - the SDK has intentional backflow from the VMR to sync the copy of the SDK with the VMR, even though the sdk is not what the build gets created off of anymore. Based on the discussion above, I'll close the PR and let a new PR flow with updates. Thank you! |
|
I think it should be source enabled, so that you get source code updates for the 2xx SDK into this repo. |
|
I deleted the subscription here and configured the backflow subscription correctly. We will check if the branches have not diverged and a BF will open. |
This pull request updates the following dependencies
From https://github.com/dotnet/dotnet