[dotnet-cli] prompt for target framework using `Spectre.Console` #51509

jonathanpeppers · 2025-10-31T13:58:35Z

Implements the first part of the spec mentioned in:

sdk/documentation/specs/dotnet-run-for-maui.md

Lines 35 to 46 in 522c88a

    
           * "Pre-run evaluation" 
        
             * If the project is multi-targeted, containing the 
        
               `$(TargetFrameworks)` property _and_ that property has more than 
        
               one item in it, and `-f` was not supplied... 
        
               * Prompt the user to select from a list of the 
        
                 `$(TargetFrameworks)` 
        
               * Non-interactive mode will give a friendly error message, 
        
                 suggesting to supply the `-f` property, listing available target 
        
                 frameworks in the project.

Add interactive target framework selection to dotnet run

When running a multi-targeted project without specifying --framework, dotnet run now:

Prompts interactively (using Spectre.Console) to select a framework with arrow keys
Shows a formatted error list in non-interactive mode with available frameworks
Handles selection early before project build/evaluation
Removes redundant multi-TFM error checking from ThrowUnableToRunError()
Adds a few unit tests to validate these changes.

This is currently WIP, as it introduces a "pre-built" Spectre.Console that I will need to setup in source-build in a PRs elsewhere.

Implements the first part of the spec mentioned in: https://github.com/dotnet/sdk/blob/522c88a6abfc4a011556f839d15844d07ba62cd9/documentation/specs/dotnet-run-for-maui.md?plain=1#L35-L46 Add interactive target framework selection to `dotnet run` When running a multi-targeted project without specifying `--framework`, `dotnet run` now: * Prompts interactively (using `Spectre.Console`) to select a framework with arrow keys * Shows a formatted error list in non-interactive mode with available frameworks * Handles selection early before project build/evaluation * Removes redundant multi-TFM error checking from `ThrowUnableToRunError()` * Adds a few unit tests to validate these changes. This is currently WIP, as it introduces a "pre-built" `Spectre.Console` that I will need to setup in source-build in a PRs elsewhere.

So it doesn't require `mono`

There are other tests that do this

This test fails after I made it check TF at runtime. This was not even the existing behavior, I think we can remove this test.

jonathanpeppers · 2025-10-31T13:59:03Z

/azp run sdk-unified-build

azure-pipelines · 2025-10-31T13:59:10Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copilot

Pull Request Overview

This PR adds interactive target framework selection to the dotnet run command for multi-targeted projects. When a multi-targeted project is run without specifying a framework, the command now prompts the user to select one in interactive mode, or displays a helpful error message with available frameworks in non-interactive mode.

Introduces TargetFrameworkSelector class to handle framework selection logic
Adds Spectre.Console package for interactive prompting
Updates error handling to show available frameworks and example commands
Includes comprehensive integration tests for framework selection scenarios

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/dotnet.Tests/CommandTests/Run/GivenDotnetRunSelectsTargetFramework.cs	Adds comprehensive integration tests for target framework selection behavior
test/TestAssets/TestProjects/DotnetRunMultiTarget/Program.cs	Test project that outputs target framework information
test/TestAssets/TestProjects/DotnetRunMultiTarget/DotnetRunMultiTarget.csproj	Multi-targeted test project configuration
src/Cli/dotnet/dotnet.csproj	Adds Spectre.Console package reference
src/Cli/dotnet/Commands/xlf/*.xlf	Adds localization entries for new UI strings (state=new)
src/Cli/dotnet/Commands/Run/TargetFrameworkSelector.cs	New class implementing framework selection logic
src/Cli/dotnet/Commands/Run/RunCommand.cs	Integrates framework selection into run command execution flow
src/Cli/dotnet/Commands/CliCommandStrings.resx	Adds new localizable strings for framework selection UI
Directory.Packages.props	Adds Spectre.Console version 0.52.0

Copilot · 2025-10-31T14:09:08Z

src/Cli/dotnet/Commands/Run/TargetFrameworkSelector.cs

+            using var collection = new ProjectCollection(globalProperties: globalProperties);
+            project = collection.LoadProject(projectFilePath);


The ProjectCollection is disposed immediately after loading the project, but the project variable is used outside the using block (line 49). This could lead to issues since the project is part of the collection that's being disposed. Consider moving the property value retrieval inside the using block or restructuring to avoid using the project after its collection is disposed.

src/Cli/dotnet/Commands/Run/TargetFrameworkSelector.cs

src/Cli/dotnet/Commands/Run/RunCommand.cs

Co-authored-by: Copilot <[email protected]>

NikolaMilosavljevic · 2025-10-31T17:58:59Z

/azp run sdk-unified-build

azure-pipelines · 2025-10-31T17:59:11Z

Azure Pipelines successfully started running 1 pipeline(s).

akoeplinger · 2025-11-03T09:48:39Z

Please also add Spectre.Console here:

sdk/eng/Signing.props

Lines 60 to 67 in 6a6992f

    
               ReSign 3rd party files that we use in the product 
        
             --> 
        
             <ItemGroup> 
        
               <FileSignInfo Include="MessagePack.Annotations.dll" CertificateName="$(ExternalCertificateId)" /> 
        
               <FileSignInfo Include="MessagePack.dll" CertificateName="$(ExternalCertificateId)" /> 
        
               <FileSignInfo Include="Nerdbank.Streams.dll" CertificateName="$(ExternalCertificateId)" /> 
        
               <FileSignInfo Include="Newtonsoft.Json.dll" CertificateName="$(ExternalCertificateId)" /> 
        
               <FileSignInfo Include="Valleysoft.DockerCredsProvider.dll" CertificateName="$(ExternalCertificateId)" />

jonathanpeppers · 2025-11-03T14:25:56Z

/azp run sdk-unified-build

azure-pipelines · 2025-11-03T14:26:10Z

Azure Pipelines successfully started running 1 pipeline(s).

NikolaMilosavljevic · 2025-11-03T17:24:31Z

sdk-unified-build pipeline is failing to synchronize the VMR. I've never seen this error before:

info: Rebasing darc/forward/00f07cf-be28ec7 onto HEAD...
dbug: Executing command: 'git -C /__w/1/vmr checkout HEAD'
dbug: Executing command: 'git -C /__w/1/vmr merge --squash darc/forward/00f07cf-be28ec7'
dbug: Executing command: 'git -C /__w/1/vmr branch -D darc/forward/00f07cf-be28ec7'
dbug: Executing command: 'git -C /__w/1/vmr show HEAD:src/source-manifest.json'
dbug: Executing command: 'git -C /__w/1/vmr add /__w/1/vmr/src/source-manifest.json'
fail: Failed to synchronize repo to VMR
      Failed to delete branch darc/forward/00f07cf-be28ec7 in /__w/1/vmr
      Exit code: 1
      Std err:
      error: cannot delete branch 'darc/forward/00f07cf-be28ec7' used by worktree at '/__w/1/vmr'

@premun @dkurepa do you know what might be going on here? Build

premun · 2025-11-03T19:47:10Z

@NikolaMilosavljevic same as here: dotnet/source-build-reference-packages#1447 (comment)

You will have to pin darc for the time being (either in dotnet-tools.json or like this)

…ks lists

baronfel

This checks my boxes:

supports long lists via scrolling
is searchable
has directions/feedback for users
has good defaults for the common cases

I did a spot-check against the way the Aspire CLI uses prompts and this is right in line.

jonathanpeppers added 8 commits October 23, 2025 12:40

Fix for .sln file passed in

f5b4ff4

Use Interactive property

0c1445e

Update GivenDotnetRunSelectsTargetFramework.cs

78afad3

So it doesn't require `mono`

Remove duplicative tests

ea80a04

There are other tests that do this

Better assertion

36e5271

Skip previous TFMs on arm64, x64 passes on these

6f66408

Remove ItPrefersExplicitFrameworkOptionOverProperty

ae1b1d7

This test fails after I made it check TF at runtime. This was not even the existing behavior, I think we can remove this test.

Copilot AI review requested due to automatic review settings October 31, 2025 13:58

jonathanpeppers mentioned this pull request Oct 31, 2025

[dotnet-cli] prompt for target framework using Spectre.Console #51430

Closed

github-actions bot added the Area-Infrastructure label Oct 31, 2025

Copilot AI reviewed Oct 31, 2025

View reviewed changes

Update src/Cli/dotnet/Commands/Run/RunCommand.cs

e18870a

Co-authored-by: Copilot <[email protected]>

Sign Spectre.Console.dll

9141a23

build-analysis bot mentioned this pull request Nov 3, 2025

Template engine tests hitting known parallelism issue in GetVisualStudioInstances #44878

Open

baronfel requested review from MiYanni and dsplaisted November 3, 2025 19:03

baronfel added Area-Run Issues relating to `dotnet run` Area-CLI and removed Area-Infrastructure labels Nov 3, 2025

small tweaks to enable running against singular-valued targetframewor…

3847cfb

…ks lists

Add EnableSearch() w/ localization support

18241ce

baronfel approved these changes Nov 3, 2025

View reviewed changes

	* "Pre-run evaluation"

	* If the project is multi-targeted, containing the
	`$(TargetFrameworks)` property _and_ that property has more than
	one item in it, and `-f` was not supplied...

	* Prompt the user to select from a list of the
	`$(TargetFrameworks)`

	* Non-interactive mode will give a friendly error message,
	suggesting to supply the `-f` property, listing available target
	frameworks in the project.

		using var collection = new ProjectCollection(globalProperties: globalProperties);
		project = collection.LoadProject(projectFilePath);

[dotnet-cli] prompt for target framework using Spectre.Console #51509

Are you sure you want to change the base?

[dotnet-cli] prompt for target framework using Spectre.Console #51509

Conversation

jonathanpeppers commented Oct 31, 2025

Uh oh!

jonathanpeppers commented Oct 31, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NikolaMilosavljevic commented Oct 31, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

akoeplinger commented Nov 3, 2025

Uh oh!

jonathanpeppers commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

NikolaMilosavljevic commented Nov 3, 2025

Uh oh!

premun commented Nov 3, 2025

Uh oh!

baronfel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[dotnet-cli] prompt for target framework using `Spectre.Console` #51509

[dotnet-cli] prompt for target framework using `Spectre.Console` #51509

baronfel left a comment •

edited

Loading