[wasm] Embed HotReload in WebAssembly SDK #52710
Draft
+49
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
changed the title
maraf
commented
Jan 29, 2026
| <Target Name="_ImplicitlyReferenceHotReload" BeforeTargets="ResolveProjectStaticWebAssets" AfterTargets="ResolveStaticWebAssetsConfiguration" Condition="'$(_WasmEnableHotReload)' == 'true'"> | ||
| <PropertyGroup> | ||
| <_WasmHotReloadRoot>$([MSBuild]::NormalizeDirectory($(MSBuildThisFileDirectory), '..', 'hotreload'))</_WasmHotReloadRoot> | ||
| <_WasmHotReloadDllPath Condition="$([MSBuild]::VersionGreaterThanOrEquals('$(TargetFrameworkVersion)', '10.0'))">net10.0</_WasmHotReloadDllPath> |
Member
Author
There was a problem hiding this comment.
@tmat Do you prefer to multi-target the dll or pin it to .NET 10?
Member
There was a problem hiding this comment.
Let's pin to .NET 10 until we need runtime features that need higher version. It's simpler and reduces SDK size.
Member
There was a problem hiding this comment.
Also, let's target release/10.0.3xx branch instead of main.
tmat
reviewed
Jan 29, 2026
| <!-- NuGet --> | ||
| <IsPackable>true</IsPackable> | ||
| <IsShipping>true</IsShipping> | ||
| <IsShippingPackage>true</IsShippingPackage> |
Member
There was a problem hiding this comment.
lines 14-17 shouldn't needed anymore.
tmat
reviewed
Jan 29, 2026
| @@ -47,6 +47,14 @@ | |||
| <Pack>true</Pack> | |||
| <PackagePath>Sdk</PackagePath> | |||
| </AdditionalContent> | |||
| <AdditionalContent Include="$(ArtifactsBinDir)\Microsoft.DotNet.HotReload.WebAssembly.Browser\$(Configuration)\**\*.*"> | |||
Member
There was a problem hiding this comment.
Shouldn't this come from a project reference? Otherwise, the build graph is not going to have the dependency edge and build may fail depending on the order in which the projects are built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a PackageReference with content shipped inside of the SDK.
It requires to manually reference the dll and define a StaticWebAsset for JSInitializer.
Fixes #49877
Fixes #52686
Fixes dotnet/aspnetcore#65261