Skip to content

chore(deploy/docker-compose): update scheduleTimeout and pieceTimeout for dfdameon config#4049

Merged
Liam-Zhao merged 1 commit intomainfrom
feature/config
May 8, 2025
Merged

chore(deploy/docker-compose): update scheduleTimeout and pieceTimeout for dfdameon config#4049
Liam-Zhao merged 1 commit intomainfrom
feature/config

Conversation

@gaius-qi
Copy link
Copy Markdown
Member

@gaius-qi gaius-qi commented May 8, 2025

Description

This pull request updates timeout configurations in the client.template.yaml file to improve download and scheduling behavior. The changes include increasing timeouts for downloading pieces and scheduling interactions, along with detailed documentation for the scheduling timeout to guide configuration.

Timeout Configuration Updates:

  • Piece Timeout: Increased pieceTimeout from 30 seconds to 60 seconds to allow more time for downloading individual pieces from the source. ([deploy/docker-compose/template/client.template.yamlL33-R33](https://github.com/dragonflyoss/dragonfly/pull/4049/files#diff-7eafc0d242243c7242afd56d770e5493e773112d999d4ab7b1321cfd90590efbL33-R33))
  • Schedule Timeout: Updated scheduleTimeout from 30 seconds to 3 hours, with an expanded comment explaining its purpose, behavior, and configuration guidance to avoid premature timeouts during scheduling interactions. ([deploy/docker-compose/template/client.template.yamlL79-R108](https://github.com/dragonflyoss/dragonfly/pull/4049/files#diff-7eafc0d242243c7242afd56d770e5493e773112d999d4ab7b1321cfd90590efbL79-R108))

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

… for dfdameon config

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.3.0 milestone May 8, 2025
@gaius-qi gaius-qi self-assigned this May 8, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner May 8, 2025 14:35
@gaius-qi gaius-qi added the enhancement New feature or request label May 8, 2025
Copy link
Copy Markdown

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) May 8, 2025 14:38
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.35%. Comparing base (545f8c0) to head (9bfac33).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4049      +/-   ##
==========================================
- Coverage   34.43%   34.35%   -0.08%     
==========================================
  Files         344      344              
  Lines       40299    40299              
==========================================
- Hits        13875    13843      -32     
- Misses      25513    25539      +26     
- Partials      911      917       +6     
Flag Coverage Δ
unittests 34.35% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Liam-Zhao Liam-Zhao merged commit 9c60d90 into main May 8, 2025
31 of 32 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/config branch May 8, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants