Skip to content

fix(workspace): preserve Base product content - #9

Merged
DR-Univer merged 1 commit into
mainfrom
fix/workspace-base-canvas-layout
Aug 21, 2026
Merged

fix(workspace): preserve Base product content#9
DR-Univer merged 1 commit into
mainfrom
fix/workspace-base-canvas-layout

Conversation

@DR-Univer

Copy link
Copy Markdown
Member

Summary

  • remove the Base-specific DOM override that hid product-owned sidebar content
  • remove the negative Canvas margin that clipped the Base summary bar by 36px
  • keep Workspace ribbon, footer, and collaboration chrome disabled through supported plugin configuration
  • update regression coverage to reject Base host CSS that changes product Canvas geometry

Validation

  • pnpm --filter @univerjs/univer-workspace test (30 files, 139 tests)
  • pnpm --filter @univerjs/univer-workspace exec vitest run test/unit/editor-integration-assets.test.ts (6 tests)
  • pnpm --filter @univerjs/univer-workspace typecheck
  • git diff --check origin/main...HEAD
  • browser geometry: Base Canvas/content bottom = 719px, Workspace shell bottom = 720px, Canvas margin-bottom = 0px

Remove host-level DOM and negative-margin overrides so the Base canvas and summary bar keep their SDK layout while ribbon and footer chrome remain disabled through plugin configuration.
@DR-Univer
DR-Univer merged commit bc11ddd into main Aug 21, 2026
1 check passed
@DR-Univer
DR-Univer deleted the fix/workspace-base-canvas-layout branch August 21, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant