Skip to content

fix(workspace): preserve Base product content #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DR-Univer merged 1 commit into from
Aug 21, 2026
Merged

fix(workspace): preserve Base product content #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions apps/workspace/test/unit/editor-integration-assets.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,13 @@ describe("editor integration assets", () => {
]);
});

it("keeps the Base-only status and footer out of the Workspace shell", () => {
it("keeps Base chrome out without clipping product content", () => {
expect(editorSources.base).toContain("hideCollaborationStatus: true");
expect(editorSources.base).toContain("toolbar: false");
expect(editorSources.base).toContain("collaborationStatus: false");
expect(editorSources.base).toContain("footer: false");
expect(globalStyles).toContain(
'[id^="univer-base-"] [data-u-comp="base-table-sidebar"] > :last-child'
);
expect(globalStyles).toContain(
'[id^="univer-base-"] [data-u-comp="base-canvas-container"]'
);
expect(globalStyles).not.toContain('[id^="univer-base-"]');
expect(globalStyles).not.toContain("margin-bottom: -36px");
});

it("registers the supported output plugins for each editor", () => {
Expand Down
9 changes: 0 additions & 9 deletions apps/workspace/web/src/app/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,15 +247,6 @@
height: 100%;
}

/* Base renders its own sidebar/canvas footer outside UniverUI's footer slot. */
[id^="univer-base-"] [data-u-comp="base-table-sidebar"] > :last-child {
display: none;
}

[id^="univer-base-"] [data-u-comp="base-canvas-container"] {
margin-bottom: -36px;
}

/* ------------------------------------------------------------------ */
/* Sonner toast alignment with the design language */
/* ------------------------------------------------------------------ */
Expand Down
Loading