Skip to content

feat(embed): add shared embed runtime - #7089

Merged
jikkai merged 214 commits into
devfrom
feat/embed-first-version
Jul 9, 2026
Merged

feat(embed): add shared embed runtime#7089
jikkai merged 214 commits into
devfrom
feat/embed-first-version

Conversation

@DR-Univer

@DR-Univer DR-Univer commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Add OSS @univerjs/embed and @univerjs/embed-ui packages.
  • Register docs/sheets embed host and guest capabilities with resource-backed descriptors.
  • Add shared UI services for host lifecycle, mount, menu override, floating activation, screenshot, undo bridge, child scoped runtime, and order-independent capability registration.
  • Keep slide product integration out of OSS; pro slide registers its own embed capabilities.

Validation

  • pnpm --filter @univerjs/embed typecheck
  • pnpm --filter @univerjs/embed-ui typecheck
  • pnpm --filter univer-examples-pro esbuild:demo
  • Dependency scan confirmed model packages do not depend on @univerjs/embed-ui.
  • Confirmed the OSS PR no longer changes packages/slides or packages/slides-ui.

Notes

  • Pre-commit hook was bypassed because the current ESLint setup reports a react/use-memo plugin rule mismatch before linting the staged changes.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch 3 times, most recently from dcc6885 to 210ed8b Compare June 18, 2026 17:20
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Playwright test results

passed  7 passed

Details

stats  7 tests across 3 suites
duration  3 minutes, 12 seconds
commit  023c1cf
info  For more information, see full report and artifacts

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.01114% with 1037 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.10%. Comparing base (20a7103) to head (023c1cf).

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 58.15% 172 Missing ⚠️
...ts-ui/src/views/sheet-container/SheetContainer.tsx 0.00% 84 Missing ⚠️
...eets-formula-ui/src/views/formula-editor/index.tsx 36.43% 82 Missing ⚠️
packages/docs/src/embed-host-anchor.ts 4.87% 78 Missing ⚠️
...formula-editor/hooks/use-sheet-selection-change.ts 54.42% 67 Missing ⚠️
...-ui/src/views/editor-container/EditorContainer.tsx 76.13% 58 Missing ⚠️
...iews/formula-editor/hooks/use-formula-selection.ts 25.97% 57 Missing ⚠️
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarTabs.tsx 0.00% 39 Missing ⚠️
...s-ui/src/services/doc-embed-integration.service.ts 42.62% 35 Missing ⚠️
...ui/src/views/formula-editor/hooks/use-highlight.ts 12.90% 27 Missing ⚠️
... and 57 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7089      +/-   ##
==========================================
- Coverage   80.14%   80.10%   -0.05%     
==========================================
  Files        2544     2561      +17     
  Lines      155563   158258    +2695     
  Branches    36600    37185     +585     
==========================================
+ Hits       124679   126770    +2091     
- Misses      30840    31442     +602     
- Partials       44       46       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch from 1e52f27 to d7d1c1c Compare June 21, 2026 18:31
@DR-Univer
DR-Univer marked this pull request as ready for review June 21, 2026 19:31
@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch 2 times, most recently from 23b6ad7 to f4e1d50 Compare June 25, 2026 11:39
@jikkai
jikkai marked this pull request as draft June 26, 2026 09:22
@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch from 3905af7 to 2dff337 Compare June 27, 2026 14:04
Comment thread packages/design/src/components/button/Button.tsx Outdated
Comment thread packages/design/src/components/dropdown-menu/__tests__/primitive.spec.tsx Outdated
Comment thread packages/design/src/components/dropdown-menu/DropdownMenuPrimitive.tsx Outdated
Comment thread packages/design/src/components/dropdown/__tests__/index.spec.tsx Outdated
Comment thread packages/design/src/components/dropdown/PopoverPrimitive.tsx Outdated
Comment thread pnpm-workspace.yaml Outdated
Comment thread pnpm-workspace.yaml Outdated
Comment thread packages/ui/src/views/components/ribbon/Ribbon.tsx Outdated
Comment thread packages/ui/src/views/emoji-picker/emojis.generated.ts Outdated
@DR-Univer
DR-Univer marked this pull request as ready for review June 30, 2026 08:35
Comment thread examples/src/sheets/custom/custom-range-popup/simple-range-popup.tsx Outdated
Comment thread packages/docs-ui/src/plugin.spec.ts Outdated
Comment thread packages/docs-ui/src/EmbedFloatingMenu.tsx Outdated
@hexf00
hexf00 force-pushed the feat/embed-first-version branch 2 times, most recently from 4194d91 to 9d8ead7 Compare June 30, 2026 11:04
@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch 3 times, most recently from 4e281fa to a7fa4a2 Compare July 7, 2026 01:34
@jikkai
jikkai force-pushed the feat/embed-first-version branch from 559a2ed to 532b148 Compare July 7, 2026 06:23
@jikkai
jikkai marked this pull request as draft July 7, 2026 07:01
@DR-Univer
DR-Univer marked this pull request as ready for review July 8, 2026 01:02
@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch from 57d02f9 to e2c85ab Compare July 8, 2026 01:16
Comment thread packages/design/src/components/dropdown/PopoverPrimitive.tsx
Comment thread examples/src/sheets/custom/custom-float-dom/float-dom.ts
Comment thread examples/src/sheets/custom/custom-register-event.ts
Comment thread packages/core/src/services/command/command.service.ts Outdated
Comment thread packages/core/src/index.ts Outdated
Comment thread packages/embed-ui/src/plugin.ts Outdated
@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch from 65eb883 to 72a6926 Compare July 8, 2026 07:07
Comment thread packages/core/package.json Outdated
@DR-Univer
DR-Univer force-pushed the feat/embed-first-version branch from fd53a82 to 9cf7b79 Compare July 8, 2026 13:29
@jikkai
jikkai merged commit 6078ae8 into dev Jul 9, 2026
21 checks passed
@jikkai
jikkai deleted the feat/embed-first-version branch July 9, 2026 04:04
siam-ese pushed a commit that referenced this pull request Jul 9, 2026
Co-authored-by: 白熱 <sonne@asaki.me>
Co-authored-by: hexf00 <hexf00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants