Refactor CI scripts and test fixes#304
Merged
Merged
Conversation
cec16c1 to
1b39e7a
Compare
849295b to
4b0cb8b
Compare
valterfrancisco-dremio
previously approved these changes
Aug 12, 2025
91a8452
91a8452 to
7e7efa9
Compare
7e7efa9 to
9d3c7b0
Compare
valterfrancisco-dremio
approved these changes
Aug 14, 2025
Contributor
valterfrancisco-dremio
left a comment
There was a problem hiding this comment.
LGTM just have one question
bcmeireles
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring CI scripts and fixing some tests.
Description
[CI Refactoring]
create_dbt_test_users.sh→ users are only needed for grants tests, which are not being ran in the current CIextract_auth_token.shand updatedcreate_and_format_sources.sh→ split authentication token extraction from sources creationcreate_env_file.sh→ removed users and roles, as they are only needed for grants testsERROR testsin artifacts as well, not onlyFAILED tests[Tests Fixing]
apply_grantsmacro to includeuser:if no prefix is defined, otherwise any rerun of the same model will lead to revoking and regranting; override tests to include prefix in the expected resultsTest Results
Changelog