Change type annotations to match returned types, fixes #35#38
Merged
Conversation
Fixes dremio#35: Pydantic output validation errors for tools GetUsefulSystemTableNames and GetSchemaOfTable
|
|
Contributor
Author
|
I have some improvements coming for this today. |
Contributor
Author
|
8f0fce1 is good to go. |
| python_classes = Test* | ||
| python_functions = test_* | ||
| asyncio_mode = strict | ||
| asyncio_default_fixture_loop_scope = function |
Contributor
Author
There was a problem hiding this comment.
I set it beacause of this warning I got when running the test:
(dremioai) ➜ dremio-mcp git:(main) ✗ uv run pytest
/Users/marijn/dev/serraict/dremio-mcp/.venv/lib/python3.12/site-packages/pytest_asyncio/plugin.py:217: PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"
warnings.warn(PytestDeprecationWarning(_DEFAULT_FIXTURE_LOOP_SCOPE_UNSET))
=================================================================================== test session starts ====================================================================================
Contributor
Author
There was a problem hiding this comment.
But tbh I did not read into the details any further, so I'm open to any other suggestions.
Contributor
Author
There was a problem hiding this comment.
| @@ -0,0 +1,61 @@ | |||
| # | |||
Contributor
There was a problem hiding this comment.
@serra I have a PR lined up for a larger change to the unit tests to validate the output types. Perhaps we can skip this test and I will follow up with that PR.
aniket-s-kulkarni
approved these changes
Jul 21, 2025
Contributor
aniket-s-kulkarni
left a comment
aniket-s-kulkarni
left a comment
There was a problem hiding this comment.
I will do a follow up PR with more of the tests mocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35 Pydantic output validation errors for tools GetUsefulSystemTableNames and GetSchemaOfTable