-
Notifications
You must be signed in to change notification settings - Fork 42
Change type annotations to match returned types, fixes #35 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−2
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @serra I have a PR lined up for a larger change to the unit tests to validate the output types. Perhaps we can skip this test and I will follow up with that PR. |
||
| # Copyright (C) 2017-2025 Dremio Corporation | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| import pytest | ||
| from unittest.mock import patch | ||
| from mcp.server.fastmcp.utilities.func_metadata import func_metadata | ||
| from dremioai.tools.tools import GetUsefulSystemTableNames, GetSchemaOfTable | ||
|
|
||
|
|
||
| async def mock_mcp_validate_tool_output(tool, *args, **kwargs): | ||
| """ | ||
| Use FastMCP's actual validation method instead of mimicking it. | ||
|
|
||
| This uses FastMCP's convert_result method which performs the exact same | ||
| validation that FastMCP does internally when processing tool outputs. | ||
| """ | ||
|
|
||
| # Get function metadata like FastMCP does | ||
| metadata = func_metadata(tool.invoke, structured_output=True) | ||
| actual_output = await tool.invoke(*args, **kwargs) | ||
|
|
||
| # Use FastMCP's actual convert_result method - this performs validation! | ||
| # If validation fails, this will raise an exception | ||
| metadata.convert_result(actual_output) | ||
|
|
||
| # If we reach here, validation passed | ||
| return True | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_get_useful_system_table_names_validation(): | ||
| tool = GetUsefulSystemTableNames() | ||
| await mock_mcp_validate_tool_output(tool) | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_get_schema_of_table_validation(): | ||
| tool = GetSchemaOfTable() | ||
| mock_schema_result = { | ||
| "fields": [ | ||
| {"name": "job_id", "type": "VARCHAR"}, | ||
| {"name": "user_name", "type": "VARCHAR"}, | ||
| ], | ||
| "text": "System jobs table", | ||
| } | ||
|
|
||
| with patch("dremioai.tools.tools.get_schema", return_value=mock_schema_result): | ||
| await mock_mcp_validate_tool_output(tool, "sys.jobs") | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serra - why do we need this for the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set it beacause of this warning I got when running the test:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But tbh I did not read into the details any further, so I'm open to any other suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference: https://pytest-asyncio.readthedocs.io/en/stable/reference/configuration.html