Skip to content

Conversation

@DieterHolvoet
Copy link
Contributor

Fixes #6480.

@weitzman
Copy link
Member

Thanks for the suggestion ... I'm not bothered by inconsistent styling. There are lots of things about io() methods that are not the same as loggers. We need not pretend that success() is a logging level. Thats a legacy Drush feature that we might as well drop because PSR loggers are never going to add a success level. I'm inclined to leave things as they are.

@weitzman weitzman changed the title Align output styling Align output styling betwen $io->success() and logger Dec 24, 2025
@DieterHolvoet
Copy link
Contributor Author

Apart from inconsistency I just think the previous styling was a lot cleaner: it takes less screen space, it's a lot less bright and hyperlinks work. Also, it's what people are used to. I don't see why a backend code refactor should result in different (and arguably worse) console output for users.

It's also not a very big change. If at some point those Robo classes aren't used anymore we just replace the constants with the strings they reference. I don't think styling our console output differently than Symfony Console is a bad thing. We're already using Laravel Prompts to get cleaner console output than what Symfony provides by default.

Regarding success messages: I don't see why we should remove those. Like you say, io() and loggers are different things. The fact that there isn't an official success PSR log level doesn't make it less useful in communicating that a command executed successfully.

@weitzman
Copy link
Member

In the end, we have a difference in taste. I like the new styling.

I'm not sure what the issue is with links. That sounds like a fixable bug.

@DieterHolvoet
Copy link
Contributor Author

Would you consider making this configurable? A bit like Gin's Layout density option, but for the CLI and only providing two options.

CleanShot 2025-12-31 at 15 38 27

@weitzman
Copy link
Member

That does not feel like a good solution to me. Lets leave this open and see if we get more +1 on the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align the output styling between io() and logger() logs

2 participants