fix(pgsql): Replace DROP TABLE with DROP SCHEMA CASCADE to handle extension-owned tables#6555
Open
o0Charly0o wants to merge 1 commit intodrush-ops:14.xfrom
Open
fix(pgsql): Replace DROP TABLE with DROP SCHEMA CASCADE to handle extension-owned tables#6555o0Charly0o wants to merge 1 commit intodrush-ops:14.xfrom
o0Charly0o wants to merge 1 commit intodrush-ops:14.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
drush sql-drop silently fails on PostgreSQL databases that have extensions installed (e.g. PostGIS, pgvector).
The current implementation generates:
When PostgreSQL extensions own certain tables (e.g. spatial_ref_sys from PostGIS), attempting to DROP TABLE them raises an error:
Since command() sets ON_ERROR_STOP=1, psql aborts on that error and no tables are dropped — but Drush reports success.
Fix
Replace the per-table DROP TABLE loop with a schema-level reset:
This approach:
Drops all user tables, views, sequences, and extension-owned objects in one atomic operation
Avoids conflicts with extension-managed tables
Restores the schema and grants so Drupal can reinstall immediately after
Testing
Verified on:
PostgreSQL with PostGIS, pg_trgm, and pgvector extensions installed
drush sql-drop -y && drush site:install -y completes successfully