Skip to content

fix(pgsql): Replace DROP TABLE with DROP SCHEMA CASCADE to handle extension-owned tables #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o0Charly0o wants to merge 1 commit into
base: 14.x
Choose a base branch
from
+12 −4
Open

fix(pgsql): Replace DROP TABLE with DROP SCHEMA CASCADE to handle extension-owned tables #6555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Sql/SqlPgsql.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,20 @@ public function createdb(bool $quoted = false): ?bool

public function drop(array $tables): ?bool
{
$return = true;
if ($tables) {
$sql = 'DROP TABLE ' . implode(', ', $tables) . ' CASCADE';
$return = $this->query($sql);
$return = $this->alwaysQuery('DROP SCHEMA public CASCADE');
if ($return) {
$return = $this->alwaysQuery('CREATE SCHEMA public');
}
if ($return) {
$dbSpec = $this->getDbSpec();
$username = $dbSpec['username'] ?? 'public';
$this->alwaysQuery("GRANT ALL ON SCHEMA public TO {$username}");
$this->alwaysQuery('GRANT ALL ON SCHEMA public TO public');
}
return $return;
}
return $return;
return true;
}

public function createdbSql($dbname, $quoted = false): string
Expand Down