Add MutableCachableProperty with tests #716
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erogers-dstl
requested review from
hpritchett-dstl
and removed request for
a team
erogers-dstl
force-pushed
the
cachable
branch
from
36c0a34 to
1d33c3a
Compare
Codecov ReportBase: 94.58% // Head: 94.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 94.58% 94.62% +0.04%
==========================================
Files 172 172
Lines 8841 8914 +73
Branches 1721 1731 +10
==========================================
+ Hits 8362 8435 +73
Misses 346 346
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to caching (for discussion only) to Steve's recently implemented one. This has the (possible?) advantage of being able to register dependent properties that are
Baseobject, and clear a cache if any properties of the dependent property are modified. See one of the tests for an example of this behaviour.