Skip to content

[MNT] compatibility with scipy>=1.14.0 and python 3.13#366

Merged
fkiraly merged 20 commits into
dswah:masterfrom
ouslan:master
Jul 23, 2025
Merged

[MNT] compatibility with scipy>=1.14.0 and python 3.13#366
fkiraly merged 20 commits into
dswah:masterfrom
ouslan:master

Conversation

@ouslan
Copy link
Copy Markdown
Contributor

@ouslan ouslan commented Dec 8, 2024

Replaces some long deprecated function calls to ensure compatibility with higher scipy and python versions.

  • Change .A to .toarray() in pygam/pygam.py
  • Change .A to .toarray() in pygam/terms.py
  • Change .A to .toarray() in pygam/tests/test_terms.py
  • Change .A to .toarray() in pygam/utils.py
  • Change .A to .toarray() and np.alltrue() to np.all()pygam/tests/test_penalties.py`

Also added environment directory to .gitignore

@ouslan ouslan mentioned this pull request Dec 8, 2024
Comment thread pygam/pygam.py
@fkiraly fkiraly changed the title Fix Issue #357 for scipy >=1.14.0 [ENH] compatibility with scipy>=1.14.0 Jul 16, 2025
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jul 16, 2025
Copy link
Copy Markdown
Owner

@dswah dswah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@fkiraly
Copy link
Copy Markdown
Collaborator

fkiraly commented Jul 17, 2025

shall we try with the new CI matrix before merging?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (a6c14e4) to head (9ab74b0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pygam/utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files          22       22           
  Lines        3202     3202           
=======================================
  Hits         3042     3042           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkiraly
Copy link
Copy Markdown
Collaborator

fkiraly commented Jul 17, 2025

i.e., merging this first: #383

@fkiraly fkiraly changed the title [ENH] compatibility with scipy>=1.14.0 [ENH] compatibility with scipy>=1.14.0 and python 3.13 Jul 23, 2025
@fkiraly fkiraly changed the title [ENH] compatibility with scipy>=1.14.0 and python 3.13 [MNT] compatibility with scipy>=1.14.0 and python 3.13 Jul 23, 2025
@fkiraly fkiraly merged commit 8b1c016 into dswah:master Jul 23, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants