fix: save enabled for new tags and update link-preview on url change#1823
Merged
steven-tey merged 2 commits intodubinc:mainfrom Dec 22, 2024
Merged
Conversation
Contributor
|
@Suksham-sharma is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
steven-tey
approved these changes
Dec 22, 2024
Collaborator
steven-tey
left a comment
There was a problem hiding this comment.
What a beautiful fix, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues in the link-builder modal:
Changes Made
Adjusted the logic for enabling the "Save" button in response to new tag creation.
Modified the update mechanism for the link preview to ensure it reflects all updates whenever the info is updated
Testing
Earlier:
Screen.Recording.2024-12-20.at.12.10.16.AM.mp4
Fixed:
Screen.Recording.2024-12-20.at.12.36.50.AM.mp4
Earlier:
Screen.Recording.2024-12-22.at.3.04.48.AM.mp4
Fixed:
Screen.Recording.2024-12-22.at.3.06.50.AM.mp4
Resolves #1812
Resolves #1781