Add Web Share Target support and Android AAB build workflow#27
Merged
Conversation
Lets other apps (e.g. Google Photos) share video files directly into Video Shrinker via the OS share sheet. Switches the PWA to a custom injectManifest service worker to intercept the share_target POST, stash the file in a cache, and hand it back to the app on next load. Also adds a manual Bubblewrap workflow to build the signed Android App Bundle for Play Store distribution as a TWA.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged the workflow for not scoping GITHUB_TOKEN permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateSWtoinjectManifest(customsrc/sw.ts) to intercept theshare_targetPOST, cache the incoming file, then hand it back to the app on the next load — the app still requires the user to pick a target size and hit Convert, it never auto-convertsworkflow_dispatch-only) GitHub Actions workflow using Bubblewrap to build a signed Android App Bundle (.aab) for Play Store distribution as a Trusted Web ActivityTest plan
npm run buildandnpm run lintpass cleanlyBuild Android AABworkflow manually and upload the resulting.aabto Play Console internal testing