bump to v1.3.2 #25
bump to v1.3.2 #25
Conversation
| [dependencies] | ||
| duckdb = { version = "1.3.1", features = ["vtab-loadable"] } | ||
| duckdb = { version = "1.3.2", features = ["vtab-loadable"] } | ||
| duckdb-loadable-macros = "0.1.5" |
There was a problem hiding this comment.
I think it'd be a good idea to update this to 0.1.9, so that template users get the latest version of all crates.
There was a problem hiding this comment.
We currently release duckdb, duckdb-loadable-macros, and libduckdb-sys together.
There was a problem hiding this comment.
oh oops I pressed merged right as you commented!
There was a problem hiding this comment.
@mlafeldt , looks like the version is the same as you've mentioned in generated Cargo.lock file:
https://github.com/hmeriann/extension-template-rs/blob/a2f4c9d0ad1c4427dca799537eea4cb13ea50898/Cargo.lock#L474
So I'll just send a new PR to update duckdb-loadable-macros in the Cargo.toml file. Does it sound right?
There was a problem hiding this comment.
Yes, that's right.
It's already the latest version in Cargo.lock because the version constraint 0.1.x allows cargo to update to 0.1.9. However, it's better to make it explicit like with the other duckdb crates.
Approved the PR. :)
There was a problem hiding this comment.
Thanks!
For the future PRs like this, where to look for the proper numbers for the duckdb-loadable-macros?
I'm updating the release check-list and it'd be nice to have this information there (if there any other ways except for running cargo check and looking up for the numbers in generated file)
There was a problem hiding this comment.
You're welcome!
I guess https://crates.io/search?q=duckdb&sort=recent-updates at the top would be easiest.
3 participants
bump to v1.3.2