Skip to content

bump to v1.3.2 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

bump to v1.3.2 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad9dd84
bump to v1.3.2
hmeriann Jul 8, 2025
a2f4c9d
bump to duckdb v1.3.2
hmeriann Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ concurrency:
jobs:
duckdb-stable-build:
name: Build extension binaries
uses: duckdb/extension-ci-tools/.github/workflows/[email protected].1
uses: duckdb/extension-ci-tools/.github/workflows/[email protected].2
with:
duckdb_version: v1.3.1
ci_tools_version: v1.3.1
duckdb_version: v1.3.2
ci_tools_version: v1.3.2
extension_name: rusty_quack
extra_toolchains: rust;python3
exclude_archs: 'wasm_mvp;wasm_eh;wasm_threads;linux_amd64_musl'
71 changes: 32 additions & 39 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ path = "src/wasm_lib.rs"
crate-type = ["staticlib"]

[dependencies]
duckdb = { version = "1.3.1", features = ["vtab-loadable"] }
duckdb = { version = "1.3.2", features = ["vtab-loadable"] }
duckdb-loadable-macros = "0.1.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be a good idea to update this to 0.1.9, so that template users get the latest version of all crates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently release duckdb, duckdb-loadable-macros, and libduckdb-sys together.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops I pressed merged right as you commented!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! 😀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlafeldt , looks like the version is the same as you've mentioned in generated Cargo.lock file:
https://github.com/hmeriann/extension-template-rs/blob/a2f4c9d0ad1c4427dca799537eea4cb13ea50898/Cargo.lock#L474

So I'll just send a new PR to update duckdb-loadable-macros in the Cargo.toml file. Does it sound right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right.

It's already the latest version in Cargo.lock because the version constraint 0.1.x allows cargo to update to 0.1.9. However, it's better to make it explicit like with the other duckdb crates.

Approved the PR. :)

Copy link
Contributor Author

@hmeriann hmeriann Jul 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
For the future PRs like this, where to look for the proper numbers for the duckdb-loadable-macros?
I'm updating the release check-list and it'd be nice to have this information there (if there any other ways except for running cargo check and looking up for the numbers in generated file)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome!

I guess https://crates.io/search?q=duckdb&sort=recent-updates at the top would be easiest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

libduckdb-sys = { version = "1.3.1", features = ["loadable-extension"] }
libduckdb-sys = { version = "1.3.2", features = ["loadable-extension"] }
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ EXTENSION_NAME=rusty_quack
USE_UNSTABLE_C_API=1

# Target DuckDB version
TARGET_DUCKDB_VERSION=v1.3.1
TARGET_DUCKDB_VERSION=v1.3.2

all: configure debug

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ to ensure the previous `make configure` step is deleted.

Then, run
```
DUCKDB_TEST_VERSION=v1.3.1 make configure
DUCKDB_TEST_VERSION=v1.3.2 make configure
```
to select a different duckdb version to test with

Expand Down
2 changes: 1 addition & 1 deletion extension-ci-tools
Open in desktop
Submodule extension-ci-tools updated 15 files
+5 −6 .github/workflows/TestCITools.yml
+28 −0 .github/workflows/_extension_distribution.yml
+3 −5 README.md
+2 −2 config/distribution_matrix.json
+1 −0 docker/linux_amd64/Dockerfile
+4 −1 docker/linux_amd64_musl/Dockerfile
+2 −0 docker/linux_arm64/Dockerfile
+36 −3 makefiles/duckdb_extension.Makefile
+11 −0 toolchains/x64-windows-static-md-release-vs2019comp.cmake
+4 −0 vcpkg_ports/README.md
+0 −377 vcpkg_ports/avro-c/avro.patch
+0 −126 vcpkg_ports/avro-c/avro_writer.patch
+0 −125 vcpkg_ports/avro-c/duckdb.patch
+0 −406 vcpkg_ports/avro-c/field_id.patch
+3 −8 vcpkg_ports/avro-c/portfile.cmake
Loading