-
Notifications
You must be signed in to change notification settings - Fork 27
Onboarding: Fix welcome message appearing off screen #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 30 Apr 2025 09:00:05 GMT Integration
File has changed Windows
File has changed Apple
File has changed |
This is a great fix, thanks @noisysocks . I'm now wondering why I chose to make the hiker position:absolute rather than fixed. It would prevent this from happening ![]() But I also wonder if it would have any other side-effects. Going to try it out locally in a bit and report back. |
@noisysocks I've been testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've committed position:fixed and will approve this based on my local testing as @shakyShane needs this fix too
@mgurgel: Sorry, I was a bit slow. Looks good to me though 👍🌈 |
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1207340338530322/task/1207201632549085?focus=true
Description
Prevent the welcome message in Onboarding from having a negative
translateY
value and appearing off screen.Testing Steps
Checklist
Please tick all that apply: