Skip to content

Onboarding: Fix welcome message appearing off screen #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Apr 28, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1207340338530322/task/1207201632549085?focus=true

Description

Prevent the welcome message in Onboarding from having a negative translateY value and appearing off screen.

Testing Steps

  1. Browse to https://deploy-preview-1650--content-scope-scripts.netlify.app/build/pages/onboarding/.
  2. Resize your browser so that the height is small.
  3. “Hi there. Ready for a faster browser that keeps you protected?” bubble should not appear off screen.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks added the bug Something isn't working label Apr 28, 2025
@noisysocks noisysocks requested review from shakyShane, mgurgel and a team as code owners April 28, 2025 05:51
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit a2d29e3
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6811e670e8b8390007fdaf20
😎 Deploy Preview https://deploy-preview-1650--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 28, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Apr 28, 2025

[Beta] Generated file diff

Time updated: Wed, 30 Apr 2025 09:00:05 GMT

Integration
    - integration/pages/onboarding/dist/index.css

File has changed

Windows
    - windows/pages/onboarding/dist/index.css

File has changed

Apple
    - dist/pages/onboarding/dist/index.css

File has changed

@mgurgel
Copy link
Contributor

mgurgel commented Apr 29, 2025

This is a great fix, thanks @noisysocks . I'm now wondering why I chose to make the hiker position:absolute rather than fixed. It would prevent this from happening

image

But I also wonder if it would have any other side-effects. Going to try it out locally in a bit and report back.

@mgurgel
Copy link
Contributor

mgurgel commented Apr 29, 2025

@noisysocks I've been testing .hiker { position: fixed } on a local preview throughout the day and couldn't find any issues -- and it fixes the hiker scrolling up. Would you mind giving it a go on your end and see if you spot anything please? If you're happy to make that change. I can approve and merge when I'm back online.

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've committed position:fixed and will approve this based on my local testing as @shakyShane needs this fix too

@mgurgel mgurgel merged commit c130623 into main Apr 30, 2025
14 checks passed
@mgurgel mgurgel deleted the randerson/fix-off-screen-welcome-message branch April 30, 2025 09:07
@noisysocks
Copy link
Contributor Author

@mgurgel: Sorry, I was a bit slow. Looks good to me though 👍🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants