New function for Slice plotting added. Bug fixing in iso lines plotter. #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function Plot Slice allows to plot a single dose slice in a flexible way: ct and dose cube are the only required parameters, but other optional, e.g. colorbar, legend, iso dose lines, line and text properties, can be specified. The bug fixing ensures that a 2D quantity is correctly called within the function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #818 +/- ##
==========================================
+ Coverage 52.41% 52.51% +0.10%
==========================================
Files 306 307 +1
Lines 19477 19564 +87
==========================================
+ Hits 10209 10275 +66
- Misses 9268 9289 +21 ☔ View full report in Codecov by Sentry. |
|
Let's change the function in the following way:
Then please create some tests for calling the function. You can use one of the tiny test data sets to have all strutctures (ct, cst, resultGUI) available. |
Ct is the only required parameter. Dose cube is optional. Option for plotting the ct added.
… dose an optional variable. plotSliceWrapper modified to deprecated function and calling plotSlice instead.
wahln
requested changes
Feb 14, 2025
| % | ||
| % %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% | ||
|
|
||
| warning('Deprecation warning: matRad_plotSliceWrapper is deprecated. Using matRad_plot_Slice instead'); |
There was a problem hiding this comment.
we have a dedicated matRad_cfg.dispDeprecationWarning(...) for this
…ompareDose: works.
wahln
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matRad_plotSlice function allows to plot one dose slice in a flexible way: ct and dose cube are the only required parameters, while other optional parameters, e.g. cts, colorbar, iso lines, contours, line and text properties, etc., can be specified in the Name-Value pair format. The changes in the iso lines plotter ensure that 2D matrices are correctly passed to the function.