[24527] Append action infix to action topics#29
Merged
Conversation
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz
requested review from
juanlofer-eprosima and
richiprosima
and removed request for
richiprosima
May 19, 2026 08:21
cferreiragonz
force-pushed
the
append_action_infix
branch
from
May 19, 2026 09:05
4fc0c66 to
b147d5c
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
May 19, 2026 09:05
juanlofer-eprosima
requested changes
May 19, 2026
juanlofer-eprosima
left a comment
juanlofer-eprosima
left a comment
Contributor
There was a problem hiding this comment.
NIT: I would change the PR name to something like "Demangle/remove action infix"
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
append_action_infix
branch
from
May 19, 2026 09:52
d2df5ca to
a90b329
Compare
Contributor
Author
|
I have removed uncrustify changes as suggested by @juanlofer-eprosima. They will be targeted in a separated PR |
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
append_action_infix
branch
from
May 19, 2026 12:12
b9e839c to
c44b086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR automatically handles ROS 2 action infix
/_action/, allowing the user to directly use the desired action name.