Skip to content

[#24061] Fix XML profiles in DDS-Record-Replay + filter reader partitions#177

Merged
Danipiza merged 5 commits into
mainfrom
hotfix/filter
Mar 26, 2026
Merged

[#24061] Fix XML profiles in DDS-Record-Replay + filter reader partitions#177
Danipiza merged 5 commits into
mainfrom
hotfix/filter

Conversation

@Danipiza

Copy link
Copy Markdown
Contributor

Brief description

Error while replaying an entity with topic keys,

2026-03-03 11:55:47.340 [DATA_WRITER Error] Could not compute key for data -> Function create_new_change_with_params

@codecov-commenter

codecov-commenter commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.75000% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.31%. Comparing base (ff54392) to head (cf7f1b4).

Files with missing lines Patch % Lines
...e_participants/src/cpp/types/dds/TopicDataType.cpp 19.29% 35 Missing and 11 partials ⚠️
...e_participants/src/cpp/reader/dds/CommonReader.cpp 36.36% 3 Missing and 4 partials ⚠️
..._participants/src/cpp/reader/rtps/CommonReader.cpp 44.44% 3 Missing and 2 partials ⚠️
ddspipe_core/src/cpp/core/DdsPipe.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   35.96%   36.31%   +0.34%     
==========================================
  Files         174      157      -17     
  Lines       12303     7573    -4730     
  Branches     5620     3017    -2603     
==========================================
- Hits         4425     2750    -1675     
+ Misses       5018     3360    -1658     
+ Partials     2860     1463    -1397     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Danipiza Danipiza changed the title [#24061] FIX: Could not compute key for data [#24061] Fix XML profiles in DDS-Record-Replay + filter reader partitions Mar 19, 2026

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase please

Comment thread ddspipe_participants/src/cpp/types/dds/TopicDataType.cpp Outdated
Comment thread ddspipe_core/src/cpp/core/DdsPipe.cpp
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
raulojeda22
raulojeda22 previously approved these changes Mar 25, 2026

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a non-blocking issue

Comment thread ddspipe_participants/src/cpp/types/dds/TopicDataType.cpp Outdated
…d topics

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

@raulojeda22 raulojeda22 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danipiza
Danipiza merged commit e2fcc79 into main Mar 26, 2026
15 checks passed
@Danipiza
Danipiza deleted the hotfix/filter branch March 26, 2026 10:46
@Danipiza
Danipiza restored the hotfix/filter branch March 26, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants