Skip to content

[22851] Add support for bounded strings (backport #209) #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 26, 2025

Description

This PR adds support for bounded strings

@Mergifyio backport 2.1.x 2.0.x

This PR depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #209 done by [Mergify](https://mergify.com).

Sorry, something went wrong.

* Refs #22835. Add bounded strings to test_complete.idl

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22835. Add bounded strings to test_datareader.py

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22835. Regenerate test types.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #22835. Remove optional fixed string.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #22835. Add SWIG interface for fixed_size_string.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22835. Added fixed_string_field to test_modules.idl

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #22835. Fix issue.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #22835. Alternative solution.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22835. Test both approaches.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #22835. Regenerate code with Fast DDS Gen.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 5d53672)
@mergify mergify bot mentioned this pull request Feb 26, 2025
9 tasks
@MiguelCompany MiguelCompany added this to the v2.1.1 milestone Feb 26, 2025
@MiguelCompany MiguelCompany self-requested a review February 26, 2025 09:30
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant