-
Notifications
You must be signed in to change notification settings - Fork 18
[22851] Add support for bounded strings #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
8 tasks
richiware
previously approved these changes
Feb 25, 2025
Merged
8 tasks
a96cc12
to
4cdc1c5
Compare
richiware
approved these changes
Feb 26, 2025
@Mergifyio backport 2.1.x 2.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Refs #22835. Add bounded strings to test_complete.idl Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Add bounded strings to test_datareader.py Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Regenerate test types. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Remove optional fixed string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Add SWIG interface for fixed_size_string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Added fixed_string_field to test_modules.idl Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix issue. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Alternative solution. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Test both approaches. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Regenerate code with Fast DDS Gen. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 5d53672)
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Refs #22835. Add bounded strings to test_complete.idl Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Add bounded strings to test_datareader.py Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Regenerate test types. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Remove optional fixed string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Add SWIG interface for fixed_size_string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Added fixed_string_field to test_modules.idl Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix issue. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Alternative solution. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Test both approaches. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Regenerate code with Fast DDS Gen. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 5d53672)
9 tasks
This was referenced Feb 26, 2025
Mario-DL
pushed a commit
that referenced
this pull request
Jun 6, 2025
* Refs #22835. Add bounded strings to test_complete.idl Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Add bounded strings to test_datareader.py Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Regenerate test types. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Remove optional fixed string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Add SWIG interface for fixed_size_string. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Added fixed_string_field to test_modules.idl Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Fix issue. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Alternative solution. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Test both approaches. Signed-off-by: Miguel Company <[email protected]> * Refs #22835. Regenerate code with Fast DDS Gen. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 5d53672)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for bounded strings
@Mergifyio backport 2.1.x 2.0.x
This PR depends on:
Contributor Checklist
Reviewer Checklist