Skip to content

[22851] Add support for bounded strings #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 26, 2025
Merged

[22851] Add support for bounded strings #209

merged 10 commits into from
Feb 26, 2025

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Feb 24, 2025 •
edited by richiware
Loading

Description

This PR adds support for bounded strings

@Mergifyio backport 2.1.x 2.0.x

This PR depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

MiguelCompany and others added 10 commits February 21, 2025 12:29
@MiguelCompany
Refs #22835. Add bounded strings to test_complete.idl
85c75df 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Add bounded strings to test_datareader.py
51f7bfe 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Regenerate test types.
92dfbdb 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Remove optional fixed string.
2e9875c 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Add SWIG interface for fixed_size_string.
fb1fe19 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Added fixed_string_field to test_modules.idl
b84b0a6 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Fix issue.
3e9f706 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Alternative solution.
ac68daf 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Test both approaches.
89cfa77 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22835. Regenerate code with Fast DDS Gen.
4cdc1c5 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany added this to the v2.2.0 milestone Feb 24, 2025
@MiguelCompany MiguelCompany mentioned this pull request Feb 24, 2025
Merged
8 tasks
richiware
richiware previously approved these changes Feb 25, 2025
View reviewed changes
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima February 25, 2025 07:24
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 25, 2025
@mergify mergify bot mentioned this pull request Feb 25, 2025
Merged
8 tasks
@MiguelCompany MiguelCompany removed the request for review from richiprosima February 26, 2025 06:51
@MiguelCompany MiguelCompany merged commit 5d53672 into main Feb 26, 2025
8 of 10 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/22835 branch February 26, 2025 09:08
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.1.x 2.0.x

@mergify Mergify
Copy link

mergify bot commented Feb 26, 2025 •
edited
Loading

backport 2.1.x 2.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@MiguelCompany @mergify
Add support for bounded strings (#209)
51a753c 
* Refs #22835. Add bounded strings to test_complete.idl

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Add bounded strings to test_datareader.py

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Regenerate test types.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Remove optional fixed string.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Add SWIG interface for fixed_size_string.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Added fixed_string_field to test_modules.idl

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Alternative solution.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Test both approaches.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Regenerate code with Fast DDS Gen.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 5d53672)
mergify bot pushed a commit that referenced this pull request Feb 26, 2025
@MiguelCompany @mergify
Add support for bounded strings (#209)
2626872 
* Refs #22835. Add bounded strings to test_complete.idl

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Add bounded strings to test_datareader.py

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Regenerate test types.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Remove optional fixed string.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Add SWIG interface for fixed_size_string.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Added fixed_string_field to test_modules.idl

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Alternative solution.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Test both approaches.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Regenerate code with Fast DDS Gen.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 5d53672)
@mergify mergify bot mentioned this pull request Feb 26, 2025
Merged
9 tasks
This was referenced Feb 26, 2025
Open
Open
Mario-DL pushed a commit that referenced this pull request Jun 6, 2025
@MiguelCompany @Mario-DL
Add support for bounded strings (#209)
ed4e398 
* Refs #22835. Add bounded strings to test_complete.idl

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Add bounded strings to test_datareader.py

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Regenerate test types.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Remove optional fixed string.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Add SWIG interface for fixed_size_string.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Added fixed_string_field to test_modules.idl

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Fix issue.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Alternative solution.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Test both approaches.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22835. Regenerate code with Fast DDS Gen.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 5d53672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @richiware