[24046] Update security tests to use governance-based encryption configuration#6277
Conversation
e1a3c51 to
c6493c1
Compare
🧪 CI InsightsHere's what we observed from your CI run for efe835d. ❌ Job Failures
|
efe835d to
3ced539
Compare
517886f to
bb6c126
Compare
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
…on_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
2a2a18b to
02ec5b5
Compare
emiliocuestaf
left a comment
There was a problem hiding this comment.
Looks good to me (I can't approve this PR). A few comments:
- I don't think we need to test larga data in every test
- The CI seemed to exhaust all the resources in the Windows machine. This last run worked fine, but I'm a bit worried this behaviour arises again.
- It seems we fixed the mac security tests 👌
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
|
I consider failed tests unrelated. Alternative build is fixed by: #6393 |
|
@Mergifyio backport 3.4.x 3.2.x 2.14.x |
✅ Backports have been createdDetails
Cherry-pick of a1d550b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of a1d550b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Cherry-pick of a1d550b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
#6277) * Add reliability as a param to security tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Prepare XMLs to generate smime files for new tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests with access_sign in topic name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in liveliness_protection_kind/rtps_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in discovery_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for large data Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Modify performance tests to properly test access security Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Generate SMIME files from XML Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove old tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Relaxing requirements for best effor tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix some mistakes on the new tests and config files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Editing performance test files, they are ok now Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix compilation issues Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix large_data tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update sign permissions files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix transport+best_effort test cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Skip SIGN tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding some comments Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add topic for profiling tests in performance tests xml and smime Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refs #24046: Delete reliability matrix in test suite Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Avoid overload for clarification Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Update name of tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Create common methods to configure plugins Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Make basic test methods independent of Test suite class Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Add common communication test method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix only Auth security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Remove DataSharing from Security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Use common methods for configuration Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Run with both reliability tests with RTPS or submessage encryption or sign Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Templatize test_basic_secure_communication method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Do not run best_effort large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix Windows build Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Enable othercacert in 'fill_access' Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Reduce large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit a1d550b)
#6277) (#6395) * Update security tests to use governance-based encryption configuration (#6277) * Add reliability as a param to security tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Prepare XMLs to generate smime files for new tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests with access_sign in topic name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in liveliness_protection_kind/rtps_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in discovery_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for large data Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Modify performance tests to properly test access security Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Generate SMIME files from XML Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove old tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Relaxing requirements for best effor tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix some mistakes on the new tests and config files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Editing performance test files, they are ok now Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix compilation issues Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix large_data tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update sign permissions files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix transport+best_effort test cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Skip SIGN tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding some comments Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add topic for profiling tests in performance tests xml and smime Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refs #24046: Delete reliability matrix in test suite Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Avoid overload for clarification Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Update name of tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Create common methods to configure plugins Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Make basic test methods independent of Test suite class Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Add common communication test method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix only Auth security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Remove DataSharing from Security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Use common methods for configuration Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Run with both reliability tests with RTPS or submessage encryption or sign Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Templatize test_basic_secure_communication method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Do not run best_effort large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix Windows build Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Enable othercacert in 'fill_access' Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Reduce large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit a1d550b) * Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
#6277) * Add reliability as a param to security tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Prepare XMLs to generate smime files for new tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests with access_sign in topic name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in liveliness_protection_kind/rtps_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in discovery_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for large data Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Modify performance tests to properly test access security Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Generate SMIME files from XML Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove old tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Relaxing requirements for best effor tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix some mistakes on the new tests and config files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Editing performance test files, they are ok now Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix compilation issues Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix large_data tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update sign permissions files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix transport+best_effort test cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Skip SIGN tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding some comments Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add topic for profiling tests in performance tests xml and smime Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refs #24046: Delete reliability matrix in test suite Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Avoid overload for clarification Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Update name of tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Create common methods to configure plugins Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Make basic test methods independent of Test suite class Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Add common communication test method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix only Auth security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Remove DataSharing from Security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Use common methods for configuration Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Run with both reliability tests with RTPS or submessage encryption or sign Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Templatize test_basic_secure_communication method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Do not run best_effort large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix Windows build Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Enable othercacert in 'fill_access' Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Reduce large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit a1d550b) Fix conflicts Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
#6277) (#6396) * Update security tests to use governance-based encryption configuration (#6277) * Add reliability as a param to security tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Prepare XMLs to generate smime files for new tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests with access_sign in topic name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in liveliness_protection_kind/rtps_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in discovery_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for large data Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Modify performance tests to properly test access security Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Generate SMIME files from XML Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove old tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Relaxing requirements for best effor tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix some mistakes on the new tests and config files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Editing performance test files, they are ok now Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix compilation issues Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix large_data tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update sign permissions files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix transport+best_effort test cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Skip SIGN tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding some comments Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add topic for profiling tests in performance tests xml and smime Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refs #24046: Delete reliability matrix in test suite Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Avoid overload for clarification Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Update name of tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Create common methods to configure plugins Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Make basic test methods independent of Test suite class Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Add common communication test method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix only Auth security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Remove DataSharing from Security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Use common methods for configuration Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Run with both reliability tests with RTPS or submessage encryption or sign Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Templatize test_basic_secure_communication method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Do not run best_effort large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix Windows build Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Enable othercacert in 'fill_access' Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Reduce large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit a1d550b) Fix conflicts Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Description
The properties rtps.participant.rtps_protection_kind, rtps.endpoint.submessage_protection_kind, and rtps.endpoint.payload_protection_kind are not parsed in the Fast-DDS source code. These properties are set in multiple blackbox security tests, but they have no effect on the actual encryption behavior.
The only valid way to configure RTPS/endpoint protection kinds is through the governance file with the Access Control plugin enabled.
The properties rtps.participant.rtps_protection_kind, rtps.endpoint.submessage_protection_kind, and rtps.endpoint.payload_protection_kind are not parsed in the Fast-DDS source code. These properties are set in multiple blackbox security tests, but they have no effect on the actual encryption behavior.
The only valid way to configure RTPS/endpoint protection kinds is through the governance file with the Access Control plugin enabled.
This PR includes the following features:
@Mergifyio backport 3.4.x 3.3.x 3.2.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist