Skip to content

[24442] Rearrange ASAN workflow#6384

Merged
rsanchez15 merged 4 commits into
masterfrom
fix_asan_job
May 4, 2026
Merged

[24442] Rearrange ASAN workflow#6384
rsanchez15 merged 4 commits into
masterfrom
fix_asan_job

Conversation

@cferreiragonz

@cferreiragonz cferreiragonz commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR moves the build of Fast DDS Tests to the build job, giving more time to the test job to run.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added this to the v3.6.2 milestone Apr 29, 2026
@cferreiragonz
cferreiragonz requested review from richiprosima and removed request for richiprosima April 29, 2026 07:27
@github-actions github-actions Bot added the ci-pending PR which CI is running label Apr 29, 2026
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz
cferreiragonz requested review from richiprosima and removed request for richiprosima April 29, 2026 07:32
@cferreiragonz

Copy link
Copy Markdown
Contributor Author

I manually cancelled workflows non-related to Sanitizers

emiliocuestaf
emiliocuestaf previously approved these changes Apr 29, 2026

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Comment thread .github/workflows/reusable-sanitizers-ci.yml Outdated
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com>
@cferreiragonz
cferreiragonz requested a review from richiware April 30, 2026 07:21

@emiliocuestaf emiliocuestaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI passed

@cferreiragonz cferreiragonz changed the title Rearrange ASAN workflow [24442] Rearrange ASAN workflow May 4, 2026
@rsanchez15
rsanchez15 merged commit bb01a94 into master May 4, 2026
8 of 20 checks passed
@rsanchez15
rsanchez15 deleted the fix_asan_job branch May 4, 2026 07:18
@@ -11,10 +11,6 @@ on:
description: 'Run Addess Sanitizer job for Fast DDS'
required: false
type: boolean

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to make similar changes in the nightly

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants