[refactor] Simplify startup code #5701
Merged
Merged
Conversation
dizzzz
commented
Apr 13, 2025
duncdrum
reviewed
Apr 13, 2025
duncdrum
left a comment
Contributor
There was a problem hiding this comment.
Javadoc of all things is failing
line-o
reviewed
Apr 14, 2025
line-o
left a comment
Member
There was a problem hiding this comment.
This looks amazing 🤩
Could you walk us through the changes tonight?
Member
Author
|
The open questions I have
|
Member
Author
|
I tried to simplify the startup of appbundler by removing these xml files
|
dizzzz
commented
Apr 14, 2025
Contributor
|
line-o
reviewed
Apr 14, 2025
line-o
reviewed
Apr 14, 2025
dizzzz
commented
Apr 16, 2025
dizzzz
commented
Apr 16, 2025
c9eeab3 to
0508daa
Compare
Only reported by Linux build ....
2ea4525 to
06e9b99
Compare
06e9b99 to
707c4ec
Compare
adamretter
reviewed
Jul 21, 2025
adamretter
suggested changes
Jul 21, 2025
duncdrum
approved these changes
Jul 23, 2025
reinhapa
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It started with the idea to remove all old code code from jetty, as the classpath is now constructed in a different way.
The PR evolved into a significant rewrite refactoring and cleanup of the original code; Move methods to locations where used, combine functionality in a new Class, split-up the "doIt" method, with readable methods.
Summary
org.exist.start.classloader.LatestFileResolveris now moved to the webstart code inorg.exist.webstartLatestFileResolverhas been cleaned up, uses a logger, made code more readable.runEx(runArgs)to 'startExistdb(runArgs)` - characters are free these daysCompatibleJavaVersionCheckas the buggy Java15's are not relevant anymore - code remains for future usage.CompatibleJavaVersionCheckcode more readableorg/exist/start/Main.javato make it more readable, less error prone to see the flow etc.