-
Notifications
You must be signed in to change notification settings - Fork 8
Use views or templates instead of raw pointers. #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 93.43% 93.35% -0.08%
==========================================
Files 303 303
Lines 25177 24285 -892
Branches 2766 2766
==========================================
- Hits 23523 22671 -852
+ Misses 1654 1614 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9bf4e7e to
e7276ea
Compare
singhbalwinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
e7276ea to
a270b6a
Compare
a270b6a to
9b7797b
Compare
|
@singhbalwinder, all tests are passing in this pull request. Can we proceed with merging this PR? |
Replacing Raw Pointers with Template Types.
I am testing this branch in E3SM: PR #7846. After all tests pass, we can merge this PR.
This test passed successfully in Frontier:
ERS.ne4pg2_oQU480.F2010-EAMxx-MAM4xx.frontier_craygnu-mphipcc.eamxx-L72