Skip to content

Conversation

@odiazib
Copy link
Contributor

@odiazib odiazib commented May 13, 2025

Replacing Raw Pointers with Template Types.
I am testing this branch in E3SM: PR #7846. After all tests pass, we can merge this PR.
This test passed successfully in Frontier: ERS.ne4pg2_oQU480.F2010-EAMxx-MAM4xx.frontier_craygnu-mphipcc.eamxx-L72

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.35%. Comparing base (34c4d5c) to head (9b7797b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   93.43%   93.35%   -0.08%     
==========================================
  Files         303      303              
  Lines       25177    24285     -892     
  Branches     2766     2766              
==========================================
- Hits        23523    22671     -852     
+ Misses       1654     1614      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odiazib odiazib marked this pull request as ready for review May 15, 2025 15:57
@odiazib odiazib force-pushed the oscar/removing_dot_data branch from 9bf4e7e to e7276ea Compare May 27, 2025 21:30
Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@odiazib odiazib force-pushed the oscar/removing_dot_data branch from e7276ea to a270b6a Compare July 23, 2025 22:28
@odiazib odiazib changed the title Oscar/removing dot data Use views or templates instead of raw pointers. Oct 30, 2025
@odiazib odiazib force-pushed the oscar/removing_dot_data branch from a270b6a to 9b7797b Compare October 30, 2025 17:46
@odiazib
Copy link
Contributor Author

odiazib commented Nov 6, 2025

@singhbalwinder, all tests are passing in this pull request. Can we proceed with merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants