Add get_virtual_ref and all_virtual_refs functionality#1307
Open
mpiannucci wants to merge 19 commits intomainfrom
Open
Add get_virtual_ref and all_virtual_refs functionality#1307mpiannucci wants to merge 19 commits intomainfrom
get_virtual_ref and all_virtual_refs functionality#1307mpiannucci wants to merge 19 commits intomainfrom
Conversation
mpiannucci
added
the
virtual references 👻
mpiannucci
changed the title
get_virtual_ref functionalityget_virtual_ref and all_virtual_refs functionality
Member
|
I think this needs more thought - see #104 (comment). |
Member
|
Sorry @mpiannucci - despite the fact that this is not enough for me to solve the thorny problem of #104, adding these methods would still be useful. I should have approved a while ago. |
TomNicholas
approved these changes
Jan 14, 2026
icechunk/src/session.rs
Outdated
| } | ||
|
|
||
| #[instrument(skip(self))] | ||
| pub async fn all_virtual_refs( |
Member
There was a problem hiding this comment.
Is there a reason why this is on the session but get_virtual_refs, set_virtual_ref, and set_virtual_refs are all on the store?
paraseba
reviewed
Mar 20, 2026
| @@ -0,0 +1,2 @@ | |||
| [build] | |||
| rustflags=["-D", "warnings", "-W", "unreachable-pub", "-W", "bare-trait-objects"] | |||
Collaborator
There was a problem hiding this comment.
I don't think we want this here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#104
#1194