-
Notifications
You must be signed in to change notification settings - Fork 68
Add get_virtual_ref and all_virtual_refs functionality
#1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpiannucci
wants to merge
19
commits into
main
Choose a base branch
from
get-virtual-ref
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8e6223b
Bump rust lib version
mpiannucci 736ecd7
Add `get_virtual_ref` and `get_virtual_ref_async` functions to rust and
mpiannucci 8ed3564
Add all virtual refs accessor to session
mpiannucci a87bba5
Lint fixes
mpiannucci 8f068cf
Merge branch 'main' into get-virtual-ref
mpiannucci 857afce
lint
mpiannucci a91ed7e
Fix tests
mpiannucci 6d259f6
fmt
mpiannucci b8e369f
Some error handling
mpiannucci 9e194d2
More
mpiannucci a61f860
Merge branch 'main' into get-virtual-ref
TomNicholas 67d095a
fmt
TomNicholas b20f807
fix use of allow_threads
TomNicholas 44d9b9b
move get_all_virtual_refs to the store class for consistency
TomNicholas 0cc2618
update tests
TomNicholas 1e7715d
update python API
TomNicholas 1e3ef6f
Merge branch 'main' into get-virtual-ref
mpiannucci d820910
Merge branch 'main' into get-virtual-ref
TomNicholas 44a0217
python lint
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [build] | ||
| rustflags=["-D", "warnings", "-W", "unreachable-pub", "-W", "bare-trait-objects"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want this here?