Bump pre-commit ruff version + define options in pyproject.toml#1647
Open
Bump pre-commit ruff version + define options in pyproject.toml#1647
Conversation
…onsistent behavior
paraseba
approved these changes
Feb 14, 2026
|
|
||
| [tool.ruff] | ||
| fix = true | ||
| show-fixes = true |
Collaborator
There was a problem hiding this comment.
Is this standard in other projects? Isn't it weird having tools changing your code without you explicitly asking? I'm OK with if this is common.
Contributor
Author
There was a problem hiding this comment.
Hmm that is a good question actually. My goal here was to align pre-commit and manually running ruff, but after thinking about it, maybe this is a bad idea.
Contributor
Author
There was a problem hiding this comment.
But FWIW pre-commit was already doing this!
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1644
I encountered some inconsistent behavior between running the linting locally and with pre-commit. This simply bumps the pre-commit version and pins the ruff version in
pyproject.tomlto the same version. I also set the--fixand--show-fixesoptions on thepyproject.tomlrather than in pre-commit to have one central place of control.Some linting output has changed, please let me know if we should stick with the older version for consistency.