Skip to content

Bump ruff to newest version and resulting changes#1727

Merged
li-em merged 2 commits intomainfrom
bump-ruff
Mar 6, 2026
Merged

Bump ruff to newest version and resulting changes#1727
li-em merged 2 commits intomainfrom
bump-ruff

Conversation

@jbusecke
Copy link
Copy Markdown
Contributor

The ruff version was quite old 0.8.0 vs 0.15.3. I bumped the version and needed a few small changes resulting from the new version.

Let me know if these changes are not desired and I can add RUF059 to the ignore list.

@jbusecke
Copy link
Copy Markdown
Contributor Author

I think @paraseba has pointed out this exact error before, so for now I assume its upstream of this change.

@jbusecke
Copy link
Copy Markdown
Contributor Author

Ok @li-em actually just pointed out that we still have ruff in pre-commit. I missed that in #1674, apologies.

The situation is quite confusing at the moment. We have two sets of checks here:
pre-commit exclusive

  • codespell, whitespace etc

just wrapped in pre-commit

  • all the rust stuff is already just a local call to just, we don't really need PC at all here its just a convienience for people who like to have checks run at commit time

Since we do not wan't or can't implement everything in PC, I propose we go the other way around with as many of the checks as possible: Implement them as a just formula, and call that formula from pre-commit.
We could go even further and ditch PC entirely if we can replace the 'builtin' hooks with equivalent checks.

Curious to hear what folks think.

@li-em
Copy link
Copy Markdown
Contributor

li-em commented Mar 6, 2026

At the moment it is more pressing to fix the ruff version mismatch, because it is annoying to get CI failures because it uses a different version.

I added @jbusecke to #1648 (comment) to continue the conversation

@li-em li-em marked this pull request as ready for review March 6, 2026 18:32
@li-em li-em merged commit 3fc6f89 into main Mar 6, 2026
19 of 20 checks passed
@li-em li-em deleted the bump-ruff branch March 6, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants