Conversation
|
I think @paraseba has pointed out this exact error before, so for now I assume its upstream of this change. |
|
Ok @li-em actually just pointed out that we still have ruff in pre-commit. I missed that in #1674, apologies. The situation is quite confusing at the moment. We have two sets of checks here:
just wrapped in pre-commit
Since we do not wan't or can't implement everything in PC, I propose we go the other way around with as many of the checks as possible: Implement them as a just formula, and call that formula from pre-commit. Curious to hear what folks think. |
|
At the moment it is more pressing to fix the I added @jbusecke to #1648 (comment) to continue the conversation |
The ruff version was quite old
0.8.0vs0.15.3. I bumped the version and needed a few small changes resulting from the new version.Let me know if these changes are not desired and I can add
RUF059to the ignore list.