Skip to content

Bump ruff to newest version and resulting changes #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
li-em merged 2 commits into from
Mar 6, 2026
Merged

Bump ruff to newest version and resulting changes #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76e4a03
Bump ruff to newest version and resulting changes
jbusecke Feb 26, 2026
a58faa1
bump ruff in pre-commit
li-em Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
- id: mixed-line-ending

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: 'v0.8.0'
rev: 'v0.15.3'
hooks:
- id: ruff-format
- id: ruff
Expand Down
2 changes: 1 addition & 1 deletion icechunk-python/benchmarks/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def get_task_chunk_shape(
if c == s or left is None:
task_chunk_shape.append(c)
else:
q, r = divmod(s, c)
q, _ = divmod(s, c)
if q > left:
task_chunk_shape.append(left * c)
else:
Expand Down
32 changes: 16 additions & 16 deletions icechunk-python/pixi.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion icechunk-python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies = ["zarr>=3.1.0"]
dev = [
{ include-group = "test" },
"mypy",
"ruff==0.8.0",
"ruff==0.15.3",
"maturin>=1.7,<2.0",
"maturin-import-hook>=0.3.0",
]
Expand Down
6 changes: 3 additions & 3 deletions icechunk-python/tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,6 @@ def test_clear_virtual_chunk_containers_persists_through_reopen() -> None:

# VCCs should be cleared after reopen
reopened_vccs = repo.config.virtual_chunk_containers or {}
assert (
reopened_vccs == {}
), f"Expected no VCCs after reopen, got: {list(reopened_vccs.keys())}"
assert reopened_vccs == {}, (
f"Expected no VCCs after reopen, got: {list(reopened_vccs.keys())}"
)
20 changes: 10 additions & 10 deletions icechunk-python/tests/test_stateful_repo_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,16 +913,16 @@ def expire_snapshots(
)

expired_but_remaining = actual & remaining_snapshot_ids
assert (
not expired_but_remaining
), f"Snapshots marked as expired but still in ancestry: {expired_but_remaining}"

assert (
actual_deleted_branches == expected.deleted_branches
), f"deleted branches mismatch: actual={actual_deleted_branches}, expected={expected.deleted_branches}"
assert (
actual_deleted_tags == expected.deleted_tags
), f"deleted tags mismatch: actual={actual_deleted_tags}, expected={expected.deleted_tags}"
assert not expired_but_remaining, (
f"Snapshots marked as expired but still in ancestry: {expired_but_remaining}"
)

assert actual_deleted_branches == expected.deleted_branches, (
f"deleted branches mismatch: actual={actual_deleted_branches}, expected={expected.deleted_branches}"
)
assert actual_deleted_tags == expected.deleted_tags, (
f"deleted tags mismatch: actual={actual_deleted_tags}, expected={expected.deleted_tags}"
)

for branch in actual_deleted_branches:
self.maybe_checkout_branch(branch)
Expand Down