fix handling of NVHPC toolchain with HMNS#5141
fix handling of NVHPC toolchain with HMNS#5141lexming wants to merge 7 commits intoeasybuilders:developfrom
Conversation
| if any(ec.name.startswith(x) for x in CRAY_TOOLCHAIN_NAME_PREFIXES): | ||
| paths.append(os.path.join(TOOLCHAIN, ec.name, ec.version)) | ||
| # special case for NVHPC toolchains that lack standalone MPI component | ||
| elif ec.name == "NVHPC" and LooseVersion(ec.version) >= LooseVersion('25.0'): |
There was a problem hiding this comment.
I wonder if we can use this instead
elif ec.name == "NVHPC" and "GCCcore" not in {dep["name"] for dep in ec["dependencies"]}:
That follows https://github.com/easybuilders/easybuild-framework/pull/5103/changes and allows for custom easyconfigs with NVHPC >= 25.0 that are old-style (we have one of those, for historical reasons).
There was a problem hiding this comment.
good point, we can indeed replace the version check with a dependency check here.
Fixed in 18f4579
bartoldeman
left a comment
bartoldeman
left a comment
There was a problem hiding this comment.
Also, would be nice to have a testcase.
…version check to handle its hierarchical_mns modules
|
@bartoldeman I won't be adding any tests for this. We might still change this behaviour as there was some discussion to add HPCX with its own easyconfig. On top of that, such a test would need toy easyconfigs for old and new NVHPC, which is quite some work. |
|
@bartoldeman as discussed, I added the requested unit tests to |
2 participants
fixes #5115