Skip to content

fix handling of NVHPC toolchain with HMNS #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexming wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix handling of NVHPC toolchain with HMNS #5141

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
544158c
fix handling of NVHPC toolchain with HMNS
lexming Feb 25, 2026
18f4579
indentify new NVHPC easyconfigs with a dependency check instead of a …
lexming Mar 4, 2026
8e1c712
remove unusued imports from module_naming_scheme.hierarchical_mns
lexming Mar 4, 2026
105a941
add test easyconfig for NVHPC 25.9
lexming Mar 12, 2026
1e45aa6
add NVHPC unit tests to test-hierarchical-mns
lexming Mar 12, 2026
268c0a2
add NVHPC unit tests for ParametrizedMNS to test-hierarchical-mns
lexming Mar 12, 2026
0564af2
fix formatting in test-hierarchical-mns
lexming Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions easybuild/tools/module_naming_scheme/hierarchical_mns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import re

from easybuild.toolchains.gcccore import GCCcore
from easybuild.tools import LooseVersion
from easybuild.tools.build_log import EasyBuildError
from easybuild.tools.module_naming_scheme.mns import ModuleNamingScheme
from easybuild.tools.module_naming_scheme.toolchain import det_toolchain_compilers, det_toolchain_mpi
Expand Down Expand Up @@ -240,15 +241,18 @@ def det_modpath_extensions(self, ec):
raise EasyBuildError("No compiler available in toolchain %s used to install MPI library %s v%s, "
"which is required by the active module naming scheme.",
ec['toolchain'], ec['name'], ec['version'])
else:
tc_comp_name, tc_comp_ver = tc_comp_info
fullver = self.det_full_version(ec)
paths.append(os.path.join(MPI, tc_comp_name, tc_comp_ver, ec['name'], fullver))
tc_comp_name, tc_comp_ver = tc_comp_info
fullver = self.det_full_version(ec)
paths.append(os.path.join(MPI, tc_comp_name, tc_comp_ver, ec['name'], fullver))

# special case for Cray toolchains
elif modclass == MODULECLASS_TOOLCHAIN and tc_comp_info is None:
# special case for Cray toolchains
if any(ec.name.startswith(x) for x in CRAY_TOOLCHAIN_NAME_PREFIXES):
paths.append(os.path.join(TOOLCHAIN, ec.name, ec.version))
# special case for NVHPC toolchains that lack standalone MPI component
elif ec.name == "NVHPC" and LooseVersion(ec.version) >= LooseVersion('25.0'):
Copy link
Contributor

@bartoldeman bartoldeman Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can use this instead

    elif ec.name == "NVHPC" and "GCCcore" not in {dep["name"] for dep in ec["dependencies"]}:

That follows https://github.com/easybuilders/easybuild-framework/pull/5103/changes and allows for custom easyconfigs with NVHPC >= 25.0 that are old-style (we have one of those, for historical reasons).

Copy link
Contributor Author

@lexming lexming Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, we can indeed replace the version check with a dependency check here.
Fixed in 18f4579

fullver = self.det_full_version(ec)
paths.append(os.path.join(MPI, "nvidia-compilers", fullver, ec.name, fullver))

return paths

Expand Down