[Chore] #268 Fix atlas-web-core tests in the Bulk CI codebase #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FactoryIT in atlas-web-core Re-enables the test case that verifies BioEntityCardModelFactory uses the ID as the title when no name is available. This improves test coverage and ensures the expected behavior is consistently validated.
ke4
added
Improvement
Reinstated previously commented-out Gradle commands for running unit, integration, and end-to-end tests, along with JUnit result parsing for test artifacts. This ensures full test coverage and proper reporting in the CI pipeline.
Improved robustness of QC folder parsing by using `Optional` to handle unexpected folder names and updated assertion imports to use `org.hamcrest.MatcherAssert` instead of deprecated `org.junit.Assert`.
Replaced the outdated access key in the test case for fetching private experiment tracks with a new valid key. This ensures the test aligns with updated configurations and prevents potential failures caused by the old key.
Added a log statement to capture the accession of an experiment that could not be found. This helps in debugging by providing clearer context when a ResourceNotFoundException is thrown.
Need to remove this later
Need to remove this later
Remove unnecessary logging statements from the getFactors method to streamline the code and improve performance. Added a null check for the assayGroup parameter to ensure robustness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Re-enables the test case that verifies BioEntityCardModelFactory uses the ID as the title when no name is available. This improves test coverage and ensures the expected behavior is consistently validated.