[Bugfix#281] - Refactor species handling incase of unknown species and enhance landing pages #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng pages Introduced a utility method for species name processing to ensure consistency across controllers. Updated species icon handling to use a default icon when an unknown species is encountered. Improved templates for baseline and differential experiments to handle empty datasets gracefully and prevent display issues.
Extracted species name formatting logic into dedicated utility methods in both controllers. This reduces code duplication and improves readability and maintainability.
amnonkhen
previously approved these changes
Jun 10, 2025
app/src/main/java/uk/ac/ebi/atlas/controllers/page/BaselineExperimentsController.java
Outdated
Show resolved
Hide resolved
app/src/main/java/uk/ac/ebi/atlas/controllers/page/PlantExperimentsController.java
Outdated
Show resolved
Hide resolved
Replaced inline species name normalization logic with existing dedicated methods (`getNormalisedSpeciesName` and `getNormalisedSpeciesReferenceName`). Remove the redundant ` getSpeciesName ` method from both controllers to enhance code maintainability and reduce duplication.
Contributor
Author
|
I am going to merge it as @amnonkhen already approved it and I also implemented his suggestions that he also approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a utility method for species name processing to ensure consistency across controllers. Updated species icon handling to use a default icon when an unknown species is encountered. Improved templates for baseline and differential experiments to handle empty datasets gracefully and prevent display issues.