Conversation
…figuration, set to DISABLED Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
…cause ArrayOutOfBoundsException Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
marcellorinaldo
force-pushed
the
fix-wifi-ui
branch
from
b9876dd to
06dd8b3
Compare
Member
Author
|
This needs to be backported to Kura 5.6.0 maintenance branch |
marcellorinaldo
added a commit
to eclipse-kura/kura
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
salvatore-coppola
previously approved these changes
Sep 2, 2025
salvatore-coppola
pushed a commit
to eclipse-kura/kura
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
salvatore-coppola
approved these changes
Sep 2, 2025
MMaiero
pushed a commit
to eclipse-kura/kura
that referenced
this pull request
Sep 3, 2025
Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
|
MMaiero
pushed a commit
to eclipse-kura/kura
that referenced
this pull request
Sep 15, 2025
…ix channel selection on hardware tab, fix validation message on empty password [backport release-5.6.0] (#5956) fix(ui): backport of eclipse-kura/kura-management-ui#11 Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
salvatore-coppola
approved these changes
Sep 17, 2025
Member
|
@mattdibi can you approve ? I'm co-author |
mattdibi
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several fixes to the wireless section of the UI.
Initialize unconfigured wireless interfaces: this prevents a NPE when trying to use the
activeConfigobject, that might be null if the interface did not appear with a configuration saved on snapshot.Correct channel selection in hardware tab: hardware tab channel selection from
this.channelListwas done by providing the channel value instead of the actual index. For example, channel 40 will select the 40th element ofthis.channelListwhich usually does not correspond to channel 40. The worst case, if the value exceeded thethis.channelListlength, we got aArrayOutOfBoundsException.Correct label of empty passwords: validation of empty passwords was done in this order:
stringLength(255, MSGS.pwdMaxLength())noWhitespaceCharacters(MSGS.pwdWhitespaceCharacters())nonEmpty(MSGS.pwdEmpty())String length validator was using this predicate for evaluation:
value -> value != null && value.length() >= minSize && value.length() <= maxSize;.On empty input, the string length validator was triggered before the empty validator.