Merged
Conversation
Signed-off-by: SimoneFiorani <simone.fiorani@abinsula.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a UI bug related to password validation in WPA2/WPA3-Enterprise wireless security configuration for Station Mode. The fix simplifies password validation logic and changes the password input component to allow blank values.
Key changes:
- Simplified password validation logic to clear validators when password is not required
- Changed password input field from
NewPasswordInputto standardInputcomponent - Updated password field to allow blank values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| javaConfig.json | Adds new Java configuration file for the project |
| TabWirelessUi.java | Simplifies password validation logic by removing conditional branches and clearing validators when password is not required |
| Tab8021xUi.ui.xml | Changes password input field from custom NewPasswordInput to standard Input component |
| Tab8021xUi.java | Updates import statements and changes password field to allow blank values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
MMaiero
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a similar bug to #17 , but happening when setting
WPA2/WPA3-EnterpriseWireless Security in Station Mode