Skip to content

fix: wpa enterprise password ui bug #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMaiero merged 2 commits into from
Oct 28, 2025
Merged

fix: wpa enterprise password ui bug #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72a114
fix: wpa enterprise password ui bug
sfiorani Oct 23, 2025
86ca8e8
fix:removed javaconfig file
sfiorani Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rg.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/Tab8021xUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
package org.eclipse.kura.web.client.ui.network;

import org.eclipse.kura.web.client.messages.Messages;
import org.eclipse.kura.web.client.ui.NewPasswordInput;
import org.eclipse.kura.web.client.util.HelpButton;
import org.eclipse.kura.web.shared.model.Gwt8021xConfig;
import org.eclipse.kura.web.shared.model.Gwt8021xEap;
Expand All @@ -25,6 +24,7 @@
import org.gwtbootstrap3.client.ui.Form;
import org.gwtbootstrap3.client.ui.FormGroup;
import org.gwtbootstrap3.client.ui.FormLabel;
import org.gwtbootstrap3.client.ui.Input;
import org.gwtbootstrap3.client.ui.ListBox;
import org.gwtbootstrap3.client.ui.PanelHeader;
import org.gwtbootstrap3.client.ui.TextBox;
Expand Down Expand Up @@ -96,7 +96,7 @@ interface Tab8021xUiUiBinder extends UiBinder<Widget, Tab8021xUi> {
TextBox username;

@UiField
NewPasswordInput password;
Input password;

@UiField
TextBox keystorePid;
Expand Down Expand Up @@ -267,7 +267,7 @@ private void initPasswordTextBox() {
});

this.password.addBlurHandler(e -> this.password.validate());
this.password.setAllowBlank(false);
this.password.setAllowBlank(true);
Comment thread
MMaiero marked this conversation as resolved.
this.password.addMouseOutHandler(event -> resetHelpText());

this.password.addChangeHandler(event -> {
Expand Down
4 changes: 2 additions & 2 deletions ....eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/Tab8021xUi.ui.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
<util:HelpButton ui:field="helpPassword"/>
<b:HelpBlock color="red"
ui:field="helpblockPassword" />
<kura:NewPasswordInput type="PASSWORD" b:id="password"
ui:field="password" allowPlaceholder="true"/>
<b:Input type="PASSWORD" b:id="password"
ui:field="password" />
</b:FormGroup>

<b:FormGroup ui:field="identityKeystorePid">
Expand Down
6 changes: 2 additions & 4 deletions ...eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/TabWirelessUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,11 +1300,9 @@ private void setPasswordValidation() {
this.password.setValidatorsFrom(Optional.empty(), passwordStrengthRequirements);
this.password
.addValidator(GwtValidators.regex(REGEX_PASS_WEP, MSGS.netWifiWirelessInvalidWEPPassword()));
} else if (this.security != null && this.security.getSelectedItemText().equals(WIFI_SECURITY_NONE_MESSAGE)) {
this.password.setValidators();
} else {
passwordStrengthRequirements.allowAnyPassword();
this.password.setValidatorsFrom(Optional.empty(), passwordStrengthRequirements);
// Clears all validators when password is not required
Comment thread
MMaiero marked this conversation as resolved.
this.password.setValidators();
}
});

Expand Down